Add unsafe modifier when necessary

PublicApiGenerator · Nov 2, 2019 · 0c76ae6 · 0c76ae6
1 parent f5c4053
commit 0c76ae6
Showing 1 changed file with 29 additions and 2 deletions.
diff --git a/src/PublicApiGenerator/ApiGenerator.cs b/src/PublicApiGenerator/ApiGenerator.cs
@@ -210,7 +210,7 @@ static CodeTypeDeclaration CreateTypeDeclaration(TypeDefinition publicType, stri
             var name = publicType.Name;
 
             var isStruct = publicType.IsValueType && !publicType.IsPrimitive && !publicType.IsEnum;
-            
+
             var @readonly = isStruct && publicType.CustomAttributes.Any(a =>
                                  a.AttributeType.FullName == "System.Runtime.CompilerServices.IsReadOnlyAttribute");
 
@@ -225,7 +225,7 @@ static CodeTypeDeclaration CreateTypeDeclaration(TypeDefinition publicType, stri
                 declarationName += "static ";
 
             declarationName += name;
-            
+
             var declaration = new CodeTypeDeclaration(declarationName)
             {
                 CustomAttributes = CreateCustomAttributes(publicType, excludeAttributes),
@@ -572,6 +572,9 @@ static void AddMethodToTypeDeclaration(CodeTypeDeclaration typeDeclaration, Meth
 
             var returnType = CreateCodeTypeReference(member.ReturnType);
 
+            if (IsUnsafeSignatureType(member.ReturnType) || member.Parameters.Any(p => IsUnsafeSignatureType(p.ParameterType)))
+                returnType = MakeUnsafe(returnType);
+
             var method = new CodeMemberMethod
             {
                 Name = memberName,
@@ -586,6 +589,22 @@ static void AddMethodToTypeDeclaration(CodeTypeDeclaration typeDeclaration, Meth
             typeDeclaration.Members.Add(method);
         }
 
+        static bool IsUnsafeSignatureType(TypeReference typeReference)
+        {
+            while (true)
+            {
+                if (typeReference.IsPointer) return true;
+
+                if (typeReference.IsArray || typeReference.IsByReference)
+                {
+                    typeReference = typeReference.GetElementType();
+                    continue;
+                }
+
+                return false;
+            }
+        }
+
         static bool IsExtensionMethod(ICustomAttributeProvider method)
         {
             return method.CustomAttributes.Any(a => a.AttributeType.FullName == "System.Runtime.CompilerServices.ExtensionAttribute");
@@ -835,6 +854,9 @@ static void AddFieldToTypeDeclaration(CodeTypeDeclaration typeDeclaration, Field
             var codeTypeReference = CreateCodeTypeReference(memberInfo.FieldType);
             if (memberInfo.IsInitOnly)
                 codeTypeReference = MakeReadonly(codeTypeReference);
+            if (IsUnsafeSignatureType(memberInfo.FieldType))
+                codeTypeReference = MakeUnsafe(codeTypeReference);
+
             var field = new CodeMemberField(codeTypeReference, memberInfo.Name)
             {
                 Attributes = attributes,
@@ -852,6 +874,11 @@ static CodeTypeReference MakeReadonly(CodeTypeReference typeReference)
             return ModifyCodeTypeReference(typeReference, "readonly");
         }
 
+        static CodeTypeReference MakeUnsafe(CodeTypeReference typeReference)
+        {
+            return ModifyCodeTypeReference(typeReference, "unsafe");
+        }
+
         static CodeTypeReference ModifyCodeTypeReference(CodeTypeReference typeReference, string modifier)
         {
             using (var provider = new CSharpCodeProvider())