Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim 4 #47

Merged
merged 8 commits into from Sep 8, 2019
Merged

Slim 4 #47

merged 8 commits into from Sep 8, 2019

Conversation

mnapoli
Copy link
Member

@mnapoli mnapoli commented Aug 5, 2019

Originally #46

resolves #22

TODO:

@l0gicgate
Copy link

l0gicgate commented Aug 6, 2019

Just a heads up @mnapoli there will be upcoming breaking changes to CallableResolverInterface in Slim 4.2

I know, there’s already a lot of BC changes but unfortunately we have to do this so MiddlewareDispatcher becomes dependant on CallableResolver instead of duplicating a bunch of logic to resolve callables.

See slimphp/Slim#2780 for more information

@fritsvt fritsvt mentioned this pull request Aug 7, 2019
@mnapoli
Copy link
Member Author

mnapoli commented Aug 10, 2019

I'm putting this on hold waiting for slimphp/Slim#2793

@l0gicgate I'm commenting in the issue you linked to.

This was referenced Aug 10, 2019
@l0gicgate
Copy link

@mnapoli I think we’re in the clear here. Just released 4.2 today and we avoided all potential BCs thankfully!

@mnapoli
Copy link
Member Author

mnapoli commented Aug 21, 2019

@l0gicgate awesome, thank you for letting me know!

@xndr78
Copy link

xndr78 commented Aug 30, 2019

cannot wait for slim 4 support

@opengeek
Copy link

opengeek commented Sep 4, 2019

Is this ready to go? Is there a way to use this via composer so I can try it out on some existing projects I would like to upgrade to Slim 4?

@alturic
Copy link

alturic commented Sep 8, 2019

Any update on this? Definitely interested in testing this out on Slim 4.

@mnapoli
Copy link
Member Author

mnapoli commented Sep 8, 2019

I have updated the issue description with a TODO list of what's left to do.

I have loads of work this week, I hope to get on this next week.

@fritsvt fritsvt mentioned this pull request Sep 8, 2019
@fritsvt
Copy link
Contributor

fritsvt commented Sep 8, 2019

Hi @mnapoli Thanks for the update! I've created a new PR that solves the two todo items you mentioned here.

@mnapoli mnapoli merged commit bd11c84 into master Sep 8, 2019
@mnapoli mnapoli deleted the slim4 branch September 8, 2019 20:15
@mnapoli
Copy link
Member Author

mnapoli commented Sep 8, 2019

Merged #49, thanks @fritsvt

I have opened a PR for the documentation as well: PHP-DI/PHP-DI#682

I'll merge everything, tag, release and deploy the new docs.

Thanks everyone for the help!

@SvenRtbg
Copy link

SvenRtbg commented Sep 9, 2019

I think, with this merged PHP-DI/PHP-DI#680 can be closed, too.

@mnapoli
Copy link
Member Author

mnapoli commented Sep 10, 2019

@SvenRtbg yes thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slim 4 support
7 participants