Slim4 #49
Merged
Slim4 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
reviewed
Sep 8, 2019
| @@ -118,7 +118,7 @@ public function injects_route_placeholder_over_request_attribute() | |||
| public function resolve_controller_from_container() | |||
| { | |||
| $app = Bridge::create(); | |||
| $app->get('/', [UserController::class, 'dashboard']); | |||
There was a problem hiding this comment.
Thanks for the PR! This is a regression here, this shouldn't be changed.
This is because AppFactory::createFromContainer($container) doesn't work like the old method. AppFactory::setCallableResolver(new CallableResolver($callableResolver)); should be removed, and instead the callable resolver should be defined in the container.
There was a problem hiding this comment.
Thanks for pointing this out, I updated the PR.
|
Thanks a lot! |
This was referenced Sep 8, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions for the todo items in #47