Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some hacking today and managed to get it working in Slim 4.
I still need to clean things up and add/change tests but it all seems to work so far.
I had to change the way the App gets created because this seemed to have changed in Slim 4.
A basic example of booting up an app would now look like this:
Will continue to work on this in the coming days to hopefully get it all working.
EDIT: Changed the behaviour to still be the same as before. So the DI-Bridge App would accept the same parameters as the
Appfactory::create
method does. Only changed it so thecontainer
becomes the first parameter because that's the one people would use most.Example would now look like:
So this would create a DI container for you
I removed the ErrorTest and ContainerTest because I think that behaviour changed. But please let me know if I'm wrong there.
I can't seem to fix one of the Travis checks. So if someone knows why that's failing please let me know.
@mnapoli when you have time, please let me know what you think :)
resolves #22