Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim 4 support #46

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
language: php

php:
- 7.0
- 7.1
- 7.2

matrix:
include:
- php: 7.0
- php: 7.1
env: dependencies=lowest

sudo: false
Expand Down
5 changes: 3 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@
}
},
"require": {
"php": "~7.0",
"php": "~7.1",
"php-di/php-di": "^6.0.0",
"php-di/invoker": "^2.0.0",
"slim/slim": "^3.9.0"
"slim/slim": "^4.0.0",
"slim/psr7": "^0.4.0"
},
"require-dev": {
"phpunit/phpunit": "~6.0"
Expand Down
62 changes: 41 additions & 21 deletions src/App.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,36 +3,56 @@
namespace DI\Bridge\Slim;

use DI\ContainerBuilder;
use Invoker\Invoker;
use Invoker\ParameterResolver\AssociativeArrayResolver;
use Invoker\ParameterResolver\Container\TypeHintContainerResolver;
use Invoker\ParameterResolver\DefaultValueResolver;
use Invoker\ParameterResolver\ResolverChain;
use Psr\Container\ContainerInterface;
use Psr\Http\Message\ResponseFactoryInterface;
use Slim\Factory\AppFactory;
use \Invoker\CallableResolver as InvokerCallableResolver;
use Slim\Interfaces\CallableResolverInterface;
use Slim\Interfaces\RouteCollectorInterface;
use Slim\Interfaces\RouteResolverInterface;

/**
* Slim application configured with PHP-DI.
*
* As you can see, this class is very basic and is only useful to get started quickly.
* You can also very well *not* use it and build the container manually.
*/
class App extends \Slim\App
{
public function __construct()
{
$containerBuilder = new ContainerBuilder;
$containerBuilder->addDefinitions(__DIR__ . '/config.php');
$this->configureContainer($containerBuilder);
$container = $containerBuilder->build();
public function __construct(
?ContainerInterface $container = null,
?ResponseFactoryInterface $responseFactory = null,
?CallableResolverInterface $callableResolver = null,
?RouteCollectorInterface $routeCollector = null,
?RouteResolverInterface $routeResolver = null
) {
if ($responseFactory == null) {
$responseFactory = AppFactory::determineResponseFactory();
}
if (!$container) {
$containerBuilder = new ContainerBuilder();
$container = $containerBuilder->build();
}
parent::__construct($responseFactory, $container, $callableResolver, $routeCollector, $routeResolver);

parent::__construct($container);
}
// Set resolvers
$callableResolver = new InvokerCallableResolver($container);
AppFactory::setCallableResolver(new CallableResolver($callableResolver));

$resolvers = [
// Inject parameters by name first
new AssociativeArrayResolver(),
// Then inject services by type-hints for those that weren't resolved
new TypeHintContainerResolver($container),
// Then fall back on parameters default values for optional route parameters
new DefaultValueResolver(),
];

/**
* Override this method to configure the container builder.
*
* For example, to load additional configuration files:
*
* protected function configureContainer(ContainerBuilder $builder)
* {
* $builder->addDefinitions(__DIR__ . 'my-config-file.php');
* }
*/
protected function configureContainer(ContainerBuilder $builder)
{
$invoker = new Invoker(new ResolverChain($resolvers), $container);
$this->getRouteCollector()->setDefaultInvocationStrategy(new ControllerInvoker($invoker));
}
}
3 changes: 1 addition & 2 deletions src/CallableResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,10 @@ public function __construct(\Invoker\CallableResolver $callableResolver)
{
$this->callableResolver = $callableResolver;
}

/**
* {@inheritdoc}
*/
public function resolve($toResolve)
public function resolve($toResolve): callable
{
return $this->callableResolver->resolve($toResolve);
}
Expand Down
5 changes: 1 addition & 4 deletions src/ControllerInvoker.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public function __construct(InvokerInterface $invoker)
{
$this->invoker = $invoker;
}

/**
* Invoke a route callable.
*
Expand All @@ -34,16 +33,14 @@ public function __invoke(
ServerRequestInterface $request,
ResponseInterface $response,
array $routeArguments
) {
): ResponseInterface {
// Inject the request and response by parameter name
$parameters = [
'request' => $request,
'response' => $response,
];

// Inject the route arguments by name
$parameters += $routeArguments;

// Inject the attributes defined on the request
$parameters += $request->getAttributes();

Expand Down
78 changes: 0 additions & 78 deletions src/config.php

This file was deleted.

10 changes: 7 additions & 3 deletions tests/ApplicationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@

namespace DI\Bridge\Slim\Test;

use App\ContainerFactory;
use DI\Bridge\Slim\App;
use DI\Bridge\Slim\Test\Mock\RequestFactory;
use Exception;
use PHPUnit\Framework\TestCase;
use Slim\Http\Response;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;

class ApplicationTest extends TestCase
{
Expand All @@ -17,11 +20,12 @@ public function runs()
$app = new App;

$called = false;
$app->get('/', function () use (&$called) {
$app->get('/', function (Request $request, Response $response) use (&$called) {
$called = true;
return $response;
});

$app->callMiddlewareStack(RequestFactory::create(), new Response);
$app->handle(RequestFactory::create());
$this->assertTrue($called);
}
}
59 changes: 0 additions & 59 deletions tests/ContainerTest.php

This file was deleted.