New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce multiline_string_to_heredoc
fixer
#7665
feat: Introduce multiline_string_to_heredoc
fixer
#7665
Conversation
356a17b
to
f5b18a0
Compare
PR is done. Tested on the whole repo, all unescaping should be done correctly. |
...s/Fixtures/Integration/priority/multiline_string_to_heredoc,escape_implicit_backslashes.test
Show resolved
Hide resolved
@mvorisek I believe this fixer should be run after |
6efa8ae
to
cc82cde
Compare
966909b
to
774c0e1
Compare
This is not possible as this fixer must be run before
|
774c0e1
to
b651b32
Compare
0fe181e
to
414e64d
Compare
@mvorisek I know you want to help by keeping PRs up-to-date, but rebasing all of them does not make sense because after merging any of them the rest is outdated and they just waste CI capacity 😅. I do rebase after the review, so when it's approved and CI passes it gets merged. Parallel workflows take more time because some of the jobs are waiting for available runners. Let's do one after another 🙂. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor improvements 🙂.
ba71ac8
to
50f365b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if I can foresee possible problems that could emerge with this particular implementation, but looks good enough as initial version, so I'm fine with it - we can improve/fix it later if users report something 🙂.
50f365b
to
17b3d8d
Compare
multiline_string_to_heredoc
fixermultiline_string_to_heredoc
fixer
Thank you @mvorisek 🍻! |
fix #7554
Multiline strings breaks indentation visually, this fixer fix such strings to heredoc/nowdoc and with
heredoc_indentation
the visual code flow is then much more better.