fix: no_superfluous_phpdoc_tags must honor multiline docs
#7697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@staabm can you please confirm this fix fixes all your issues? Also thank you for #7692 (comment) test case, it was much more easier to look into it than into #7692 (comment) with many different fixers applied in consequence. |
julienfalque
reviewed
Jan 8, 2024
done |
julienfalque
approved these changes
Jan 8, 2024
Wirone
force-pushed
the
fix_7692_revert_ws_parse
branch
from
b5cc388
to
6e97241
Compare
Wirone
approved these changes
Jan 8, 2024
|
hey everyone, thanks for the fast fix. I just checked my 2 local reproduces from #7692 and can confirm these are no longer a problem. thanks again! |
here was another reproducer in the same way |
danog
pushed a commit
to zoonru/PHP-CS-Fixer
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7692