New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: @PhpCsFixer
ruleset - enable multiline_string_to_heredoc
#7706
base: master
Are you sure you want to change the base?
feat: @PhpCsFixer
ruleset - enable multiline_string_to_heredoc
#7706
Conversation
|
cc2d038
to
0830301
Compare
0830301
to
1e0f8f2
Compare
@Wirone instead of landing #7709 first I decided to help with the review as much as possible, I changed The changes made in this PR should be solely CS. All strings should be effectively unchanged. Later, we can land improvements like in #7709, but such changes will change the strings, so let's not mix them in this large PR. Can I please ask you to review this PR asap to prevent conflicts? Here is how to review it:
|
the fixer was introduced in #7665
the code is now much readable, especially test cases where multiline strings were used often