Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if getElement() is undefined before adding focus listener (Canvas) #8498

Merged
merged 2 commits into from Oct 1, 2022
Merged

Check if getElement() is undefined before adding focus listener (Canvas) #8498

merged 2 commits into from Oct 1, 2022

Conversation

Falke-Design
Copy link
Member

@Falke-Design Falke-Design commented Oct 1, 2022 •
edited

Fix #8442

@Falke-Design Falke-Design linked an issue Oct 1, 2022 that may be closed by this pull request
Tooltips throw exceptions when using vector shapes with the canvas renderer after #8247 #8442
Closed
4 tasks
mourner
mourner approved these changes Oct 1, 2022
View reviewed changes
src/layer/Tooltip.js Outdated Show resolved Hide resolved
Falke-Design
Falke-Design commented Oct 1, 2022
View reviewed changes
src/layer/Tooltip.js Outdated Show resolved Hide resolved
src/layer/Tooltip.js Outdated Show resolved Hide resolved
@Falke-Design Falke-Design merged commit e61de9a into Leaflet:v1 Oct 1, 2022
@jonkoops jonkoops added blocker Critical issue or PR that must be resolved before the next release bug labels Oct 1, 2022
@jonkoops jonkoops added this to the 1.9.x milestone Oct 1, 2022
mourner pushed a commit that referenced this pull request Oct 3, 2022
@Falke-Design @mourner
Check if getElement() is undefined before adding focus listener (Ca…
579c90d 
…nvas) (#8498)
@jonkoops jonkoops mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

@Malvoz Malvoz Awaiting requested review from Malvoz

Assignees
No one assigned
Labels
blocker Critical issue or PR that must be resolved before the next release bug
Projects
None yet
Milestone
1.9.3
Development

Successfully merging this pull request may close these issues.

Tooltips throw exceptions when using vector shapes with the canvas renderer after #8247
3 participants
@Falke-Design @mourner @jonkoops