Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.9.2 #8522

Closed
jonkoops opened this issue Oct 4, 2022 · 17 comments
Closed

Release 1.9.2 #8522

jonkoops opened this issue Oct 4, 2022 · 17 comments
Assignees
Labels
workflow Anything related to Leaflet development process and tools
Milestone

Comments

@jonkoops
Copy link
Collaborator

jonkoops commented Oct 4, 2022

Creating this issue to coordinate the release of 1.9.2. cc @mourner @Falke-Design @Malvoz

@jonkoops jonkoops added feature needs triage Triage pending workflow Anything related to Leaflet development process and tools and removed feature needs triage Triage pending labels Oct 4, 2022
@jonkoops jonkoops added this to the 1.9.x milestone Oct 4, 2022
@jonkoops
Copy link
Collaborator Author

jonkoops commented Oct 4, 2022

@jonkoops jonkoops self-assigned this Oct 4, 2022
@mourner
Copy link
Member

mourner commented Oct 4, 2022

Looks like nothing's missing, we can proceed. Copying the checklist here to track:

Releasing a new version of Leaflet

  • Ensure all blocker Critical issue or PR that must be resolved before the next release issues and pull requests are resolved.
  • Update the changelog since last release and commit.
  • Run npm version <patch | minor | major> (this will bump the version in package.json and create a new tag).
  • Run git push --follow-tags to push the commit created by NPM to Github (together with the tag).
  • Wait for the CI to complete and follow the logs to make sure it runs successfully.
  • Verify that the release was correctly published to NPM by checking:
  • Make a new release on Leaflet's GitHub release page with the most important parts of the changelog
  • Download zip archive from https://leafletjs-cdn.s3.amazonaws.com/content/leaflet/vX.X.X/leaflet.zip (where X.X.X is the new version number) and upload it as an "asset" of the GitHub release.

Updating docs after the release

  • Make a new branch for the update
  • Write a blog post about the new release and put it in /docs/_posts/ we can just add a note in the v1.9 post
  • Click here to save a snapshot
    of the version of docs prior to this release to the Internet Archive's Wayback Machine
    (and optionally, add a link to the snapshot in docs/reference-versions.html).
    (no notable changes)
  • Run npm run docs to generate the new docs/reference.html and update integrity hashes in docs/_config.yml
  • Update link to latest release in docs/download.md
  • Update the announcement section in docs/index.html
  • Commit all the changes and submit a PR for someone to review

@Falke-Design
Copy link
Member

@jonkoops looks good for me

@Falke-Design
Copy link
Member

Maybe we want to merge #8523 it's a problem sinse 1.8.0

@jonkoops
Copy link
Collaborator Author

jonkoops commented Oct 4, 2022

#8523 has been added, I will get started on the release.

@jonkoops
Copy link
Collaborator Author

jonkoops commented Oct 4, 2022

@mourner @Falke-Design got a PR up for the changelog (#8526), let me know what you think.

@mourner
Copy link
Member

mourner commented Oct 4, 2022

@jonkoops made a few edits in https://github.com/Leaflet/Leaflet/releases/tag/v1.9.2 changelog for clarity — probably worth moving over to changelog.md.

@Falke-Design
Copy link
Member

We forgot to include #8523

@mourner
Copy link
Member

mourner commented Oct 4, 2022

@Falke-Design no, it was included — see https://github.com/Leaflet/Leaflet/commits/v1

@jonkoops
Copy link
Collaborator Author

jonkoops commented Oct 4, 2022

@Falke-Design it is included in the release, but it looks like it was forgotten in the release notes.

@mourner
Copy link
Member

mourner commented Oct 4, 2022

Ah, right, the changelog — that too!

@Falke-Design
Copy link
Member

@Falke-Design it is included in the release, but it looks like it was forgotten in the release notes.

Yes sorry, that was what I ment

@jonkoops
Copy link
Collaborator Author

jonkoops commented Oct 4, 2022

@mourner @Falke-Design I added a PR to update the docs #8527.

@mourner
Copy link
Member

mourner commented Oct 4, 2022

Updated the release notes with the popup bug too.

@jonkoops
Copy link
Collaborator Author

jonkoops commented Oct 4, 2022

I'll create another PR to update the change log.

@jonkoops
Copy link
Collaborator Author

jonkoops commented Oct 4, 2022

I think we're good with all the release tasks so I am closing this issue.

@jonkoops jonkoops closed this as completed Oct 4, 2022
@Falke-Design
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow Anything related to Leaflet development process and tools
Projects
None yet
Development

No branches or pull requests

3 participants