Tooltips throw exceptions when using vector shapes with the canvas renderer after #8247

[alex4401]

Checklist

• I've looked at the documentation to make sure the behavior isn't documented and expected.
• I'm sure this is an issue with Leaflet, not with my app or other dependencies (Angular, Cordova, React, etc.).
• I've searched through the current issues to make sure this hasn't been reported yet.
• I agree to follow the Code of Conduct that this project adheres to.

Steps to reproduce

1. Use latest main (9d1a841 at the time of creating this issue)
2. Set up a map with canvas renderer and a vector shape, like a rectangle.
3. Bind a tooltip to the vector. Check JS console.
4. Move mouse over the vector. Check JS console.
5. Move mouse out of the vector. Tooltip does not disappear.

Expected behavior

Tooltip does not fail to initialise or when reacting to events. They do not require DOM elements to function.

Current behavior

Exceptions thrown on: tooltip initialisation, mouse events due to getElement calls introduced in #8247 671ebdf on a canvas-rendered shape (getElement is defined on the class, but has no element to return).

Minimal example reproducing the issue

https://codepen.io/alex4401/pen/XWqpKMW

Environment

• Leaflet version: main 9d1a841
• Browser (with version): Firefox 104.0.2, but got user reports from all other browsers
• OS/Platform (with version): Arch Linux

[IvanSanchez]

Can confirm.

[Malvoz]

Quite an oversight, should be fixed in #8251 by utilizing Canvas Sub DOM for accessible vectors:

/cc @alekzvik

[jonkoops]

This seems like something we might want to consider back-porting a fix for, WDYT? Also is 1.9.1 affected?

[alex4401]

Also is 1.9.1 affected?

Yup: https://codepen.io/alex4401/pen/VwxrJaQ

[jonkoops]

Thanks for checking @alex4401.

[jonkoops]

@Malvoz do you think we could back-port #8369 and include only the fix for this issue, without also including the new functionality?

[moosetraveller]

I came across with a similar issue by using addData when using a canvas, a separate overlay pane, and a tooltip. I assume that the issue's origin is the same source than for this issue. If my assumption is correct and if #8490 will be fixed with the bugfix for this issue, please feel free to close #8490.

[alex4401]

Yeah, that's the exact same stack trace I had. Forgot to include it above.

[mourner]

@jonkoops should we release v1.9.2 without the fix, or wait until this gets resolved? Not sure how involved this would be.

[Falke-Design]

@mourner @jonkoops I will share tomorrow morning a fix

[Falke-Design]

@mourner how should I do with making a PR for 1.9.X? Creating a PR against v1 and one for main?

[mourner]

Just make a v1 PR, we can cherry-pick later

[Falke-Design]

@mourner @jonkoops I think 1.9.2 is ready

[jonkoops]

@Falke-Design Yeah, I am going to go ahead and prep the release.