DivOverlay/Popup/Tooltip refactoring and fixes #7540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnd0e
force-pushed
the
overlay-arguments
branch
from
2f86ad7
to
d4e9813
Compare
5 tasks
johnd0e
force-pushed
the
overlay-arguments
branch
2 times, most recently
from
e33ca9c
to
750b66b
Compare
added 2 commits
November 1, 2021 13:20
1. Fix a couple of edge cases: - layer is empty FeatureGroup - FeatureGroup contains layers that are not on map 2. Make code logic more clear: - get rid of redundant first argument, as bound overlay always contains _source prop. - rename `layer` to `source` for the sake of clarity. - openPopup/Tooltip: rename `layer` to `target` for the sake of clarity. 3. Allow to prevent overlay opening gracefully on some conditions (like empty FeatureGroup)
… for public methods
johnd0e
force-pushed
the
overlay-arguments
branch
from
750b66b
to
b8f25fd
Compare
Falke-Design
approved these changes
Nov 1, 2021
mourner
approved these changes
Nov 1, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continuation of #6613.
_prepareOpen-related code logic more clearFeatureGroup)This change is