Enhance Popup/Tooltip content handling for FeatureGroup #6651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnd0e
force-pushed
the
enhance-content-function
branch
2 times, most recently
from
686d2d7
to
eb56a19
Compare
johnd0e
changed the title
johnd0e
force-pushed
the
enhance-content-function
branch
2 times, most recently
from
eaa3b31
to
1618722
Compare
johnd0e
force-pushed
the
enhance-content-function
branch
from
1618722
to
b8f25fd
Compare
In this case Popup/Tooltip is not shown (and is closed if was already opened). Useful when only some layers in FeatureGroup/GeoJSON need popups: - previously: it was necessary to attach independent popups to each sublayer - now: it's enough to have common content function attached to parent FeatureGroup
johnd0e
force-pushed
the
enhance-content-function
branch
from
b8f25fd
to
7358e74
Compare
|
@mourner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow content function to return
undefined: in this case Popup/Tooltip is not shown (and is closed if was already opened).Note: This is based on #7540 (adds a single commit)
As said in docs to
FeatureGroup(and thusGeoJSON, as it extendsFeatureGroup),bindPopupbinds a popup to all of the layers at once (likewise withbindTooltip).And what is implied (but not said explicitly) - function must return value for every layer (otherwise we get exception).
But in my practice it's more common when only some of layers need Popup/Tooltip.
This PR adds such possibility.
This change is