Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DivOverlay/Popup/Tooltip refactoring and fixes #7540

Merged
merged 2 commits into from Nov 1, 2021
Merged

DivOverlay/Popup/Tooltip refactoring and fixes #7540

merged 2 commits into from Nov 1, 2021

Commits on Nov 1, 2021

  1. DivOverlay: refactor _prepareOpen method (and related changes) 

    1. Fix a couple of edge cases:
   - layer is empty FeatureGroup
   - FeatureGroup contains layers that are not on map

2. Make code logic more clear:
   - get rid of redundant first argument, as bound overlay always contains _source prop.
   - rename `layer` to `source` for the sake of clarity.
   - openPopup/Tooltip: rename `layer` to `target` for the sake of clarity.

3. Allow to prevent overlay opening gracefully on some conditions (like empty FeatureGroup)
    johndoe committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    c3226d2 View commit details
    Browse the repository at this point in the history

  2. DivOverlay/Popup/Tooltip: refactor to avoid of undocumented arguments… 

    … for public methods
    johndoe committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    b8f25fd View commit details
    Browse the repository at this point in the history