Allow event bubbling for dropdown click

[rkulinski]

Bit explicit solution, but with the architecture I think it's the best one.

The approach with two handlers is forcing to call stopPropagation which was causing this issue to occur
#5050

[changeset-bot]

🦋 Changeset detected

Latest commit: 02b794b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
react-select	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02b794b:

Sandbox	Source
react-codesandboxer-example	Configuration

[Rall3n]

I don't think setting a hard-coded className to perform a target check on is the best alternative.
The className could easily be removed using the components prop, which would result in this check being rendered useless.

There are two approaches which I think would be better:

1. Setting an internal flag to skip the handler (similar to openAfterFocus), or
2. Using event.defaultPrevented to skip the handler if preventDefault has been called. This should work because both indicators and the control use the same event for their handlers.

[rkulinski]

@Rall3n yeah. Actually after a second thought that could be a problem if someone used same class name. I think internal flag is the best option.

[rkulinski]

Hey @Rall3n, would this PR be okay to merge?

[Rall3n]

@rkulinski Looks good, but after some consideration, I have come to the conclusion that a flag is not necessarily the best way to achieve this in terms of extensibility.

Theoretically, someone could replace the event handler using a custom component, or someone could add their own indicator. In those cases, you can't set the flag because it's not reachable in either of those.

Using event.preventDefault() and event.defaultPrevented would be more independent and much better for customization.

I apologize if this might be inconvenient for you.

[rkulinski]

@Rall3n please take a look now.

[Rall3n]

It seems like the status are not being completed or even started on commit. I don't know when it started to break.

I also don't know how to force a restart, and I don't have the ability to merge despite required status not having finished.

@rkulinski I read that reopening the PR or rebasing should retrigger the status check. If not, the last resort would be to open a a new PR.

[rkulinski]

Closing in favor of #5134