Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow event bubbling for dropdown click #5089

Closed
wants to merge 6 commits into from
Closed

Allow event bubbling for dropdown click #5089

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0aaa957
Add changeset
rkulinski Feb 28, 2022
0664913
Update tests
rkulinski Mar 2, 2022
53cc8ce
Use internal flag to skip duplicate event
rkulinski Mar 2, 2022
150c020
Use defaultPrevented instead of internal flag
rkulinski Mar 25, 2022
d6685d1
Remove stopPropagation from onClearIndicatorMouseDown
rkulinski Mar 28, 2022
02b794b
Remove stopPropagation from onMouseDown on multi select items
rkulinski Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/allow-event-bubbling-for-all-controls.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
'react-select': patch
---

Replace stopPropagation with target check.
7 changes: 6 additions & 1 deletion packages/react-select/src/Select.tsx
View file
Open in desktop
Expand Up @@ -1156,6 +1156,11 @@ export default class Select<
onControlMouseDown = (
event: React.MouseEvent<HTMLDivElement> | React.TouchEvent<HTMLDivElement>
) => {
// Event captured by dropdown indicator
// @ts-ignore
if (event.target.closest('.DropdownIndicatorContainer')) {
rkulinski marked this conversation as resolved.
Show resolved Hide resolved
return;
}
const { openMenuOnClick } = this.props;
if (!this.state.isFocused) {
if (openMenuOnClick) {
Expand Down Expand Up @@ -1202,7 +1207,6 @@ export default class Select<
this.openMenu('first');
}
event.preventDefault();
event.stopPropagation();
};
onClearIndicatorMouseDown = (
event: React.MouseEvent<HTMLDivElement> | React.TouchEvent<HTMLDivElement>
Expand Down Expand Up @@ -1776,6 +1780,7 @@ export default class Select<

return (
<DropdownIndicator
className="DropdownIndicatorContainer"
{...commonProps}
innerProps={innerProps}
isDisabled={isDisabled}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-select/src/__tests__/__snapshots__/Async.test.tsx.snap
View file
Open in desktop
Expand Up @@ -220,7 +220,7 @@ exports[`defaults - snapshot 1`] = `
/>
<div
aria-hidden="true"
class=" emotion-9"
class="DropdownIndicatorContainer emotion-9"
>
<svg
aria-hidden="true"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-select/src/__tests__/__snapshots__/AsyncCreatable.test.tsx.snap
View file
Open in desktop
Expand Up @@ -220,7 +220,7 @@ exports[`defaults - snapshot 1`] = `
/>
<div
aria-hidden="true"
class=" emotion-9"
class="DropdownIndicatorContainer emotion-9"
>
<svg
aria-hidden="true"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-select/src/__tests__/__snapshots__/Creatable.test.tsx.snap
View file
Open in desktop
Expand Up @@ -220,7 +220,7 @@ exports[`defaults - snapshot 1`] = `
/>
<div
aria-hidden="true"
class=" emotion-9"
class="DropdownIndicatorContainer emotion-9"
>
<svg
aria-hidden="true"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-select/src/__tests__/__snapshots__/Select.test.tsx.snap
View file
Open in desktop
Expand Up @@ -220,7 +220,7 @@ exports[`snapshot - defaults 1`] = `
/>
<div
aria-hidden="true"
class=" emotion-9"
class="DropdownIndicatorContainer emotion-9"
>
<svg
aria-hidden="true"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-select/src/__tests__/__snapshots__/StateManaged.test.tsx.snap
View file
Open in desktop
Expand Up @@ -220,7 +220,7 @@ exports[`defaults > snapshot 1`] = `
/>
<div
aria-hidden="true"
class=" emotion-9"
class="DropdownIndicatorContainer emotion-9"
>
<svg
aria-hidden="true"
Expand Down