Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultPrevented issue with react-beautiful-dnd #5176

Open
loun4 opened this issue May 2, 2022 · 8 comments
Open

defaultPrevented issue with react-beautiful-dnd #5176

loun4 opened this issue May 2, 2022 · 8 comments
Labels
issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet

Comments

@loun4
Copy link

loun4 commented May 2, 2022

Since the following change 150c020
React Select can no longer be opened through onControlMouseDown and the event.defaultPrevented is always true when the component is rendered inside react-beautiful-dnd.

CSB: https://codesandbox.io/s/vertical-list-forked-mucu2g?file=/index.js

@rkulinski can you consider using internal flag instead of defaultPrevented (53cc8ce) to ensure that the event is captured by dropdown indicator ?

@loun4 loun4 added the issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet label May 2, 2022
@rkulinski
Copy link
Contributor

rkulinski commented May 2, 2022

Hey. That was my initial proposal - usage of internal flag. See this conversation
#5089

Possibly this case would require some other kind of patch.

@tlenclos
Copy link

Can reproduce also after upgrading to 5.3.

@loun4
Copy link
Author

loun4 commented May 11, 2022

@Rall3n @rkulinski Is there a plan to remove the defaultPrevented or provide a way to override the default behavior ?

@kamen-kirilov
Copy link

Is there any solution to that one? Still issue with v5.6.0

@sreahard
Copy link

sreahard commented Feb 3, 2023

It would be great if there was a fix for this, I did work up a fiddle to get this working with react-beautiful-dnd, not ideal, but workable if any one else is running into this. https://codesandbox.io/s/vertical-list-forked-tqwc9v?file=/index.js

@josephnle
Copy link

I found another workaround in react-beautiful-dnd. It's still ugly but I'm not yet sure what react-select can do to accommodate the case when a library like react-beautiful-dnd binds to global mousedown.

atlassian/react-beautiful-dnd#1810 (comment)

@ranafaraznaru
Copy link

Can someone tell me why we can't select text by double click if text is inside draggable div?

@hoangmf
Copy link

hoangmf commented Oct 22, 2023

Hi everyone,
It still seems like a problem. I'm faced with it.

mdo2 added a commit to mdo2/react-select that referenced this issue Jan 22, 2024
This is intended to be a temporal fix, as I think a better solution must be developed.

Referenced issues: JedWatson#5833, JedWatson#5176

Another PRs abaout this: JedWatson#5842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet
Projects
None yet
Development

No branches or pull requests

8 participants