Bumped Symfony version

[DonCallisto]

No description provided.

[stof]

Dropping support for older PHP version in a PR described as bumping Symfony version ? That's not good description of what the PR does.

[DonCallisto]

You're right but without those drops the CI won't go green.
After this #129 is merged, this change won't be there anymore.

[stof]

I'm closing this PR, because it is not at all about supporting new Symfony versions, but about dropping some PHP versions, which is not necessary for now, and is not what this PR claims to do.

[DonCallisto]

@stof have you even read my comment?

[stof]

#132 has added support for Symfony 5, without dropping anything of the current support.

[DonCallisto]

@stof So? what's the point here? Is it a comparison?
I've explicitly stated the motivations behind this choice.
If you don't want to drop the older PHP versions let's state clearly it the related PR (#129) not here.
If the related PR was closed (and it's was not) and the red CI is acceptable from your POV I would have go with your indications.
Behaving like you have done here is a no-go from my standpoint. Yes you can act as you prefer and I can only imagine how much OSS work you have (thanks, by the way!) but this kind of miscommunication is what keep some people out of OSS contribution.

[DonCallisto]

Don’t get me wrong, I’m not complaining about having this PR closed (what you stayed in #129 is perfectly understandable), just sayin’ it would have been better to explain what supplementare work could have been done in order to make this PR acceptable.
Closing with te motivation of php version bump (that’s not the main focus of the PR) is totally unrelated as the bump itself.

[xabbuh]

@DonCallisto Can you explain what you think is missing from this PR after #132 was merged?

[DonCallisto]

I was not arguing against having close this PR.
However just bumping the minors still supported but as stof said is something you don’t want to do, and rightfully so after his explaination.