Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Symfony version #130

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions .travis.yml
Expand Up @@ -12,14 +12,12 @@ env:
- SYMFONY_PHPUNIT_DIR=$HOME/.phpunit-bridge
- SYMFONY_PHPUNIT_REMOVE='' # don't remove prophecy

php: [7.2, 7.1, 7.0, 5.6, 5.5, 5.4]
php: [7.2, 7.1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping support for older PHP version in a PR described as bumping Symfony version ? That's not good description of what the PR does.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right but without those drops the CI won't go green.
After this #129 is merged, this change won't be there anymore.


matrix:
include:
- php: 7.2
env: COMPOSER_FLAGS='--prefer-lowest --prefer-stable'
- php: 5.3
dist: precise
- php: 7.2
env: STABILITY=dev

Expand Down
4 changes: 2 additions & 2 deletions Tests/ProcessorTest.php
Expand Up @@ -17,15 +17,15 @@ class ProcessorTest extends TestCase
*/
private $processor;

protected function setUp()
protected function setUp(): void
{
parent::setUp();

$this->io = $this->prophesize('Composer\IO\IOInterface');
$this->processor = new Processor($this->io->reveal());
}

protected function tearDown()
protected function tearDown(): void
{
parent::tearDown();

Expand Down
2 changes: 1 addition & 1 deletion Tests/ScriptHandlerTest.php
Expand Up @@ -11,7 +11,7 @@ class ScriptHandlerTest extends TestCase
private $io;
private $package;

protected function setUp()
protected function setUp(): void
{
parent::setUp();

Expand Down
8 changes: 4 additions & 4 deletions composer.json
Expand Up @@ -11,13 +11,13 @@
}
],
"require": {
"php": ">=5.3.3",
"symfony/yaml": "^2.3 || ^3.0 || ^4.0"
"php": ">=7.1",
"symfony/yaml": "^3.4 || ^4.2"
},
"require-dev": {
"composer/composer": "^1.0@dev",
"symfony/filesystem": "^2.3 || ^3 || ^4",
"symfony/phpunit-bridge": "^4.0"
"symfony/filesystem": "^3.4 || ^4.2",
"symfony/phpunit-bridge": "^4.2"
},
"autoload": {
"psr-4": { "Incenteev\\ParameterHandler\\": "" }
Expand Down