Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to Symfony 5 #132

Merged
merged 4 commits into from Dec 10, 2019
Merged

Added support to Symfony 5 #132

merged 4 commits into from Dec 10, 2019

Conversation

gnugat
Copy link
Contributor

@gnugat gnugat commented Dec 3, 2019

Added support to:

  • Symfony YAML 5
  • Symfony Filesystem 5 (dev)
  • Symfony PHPUnit bridge 5 (dev)

@gnugat
Copy link
Contributor Author

gnugat commented Dec 3, 2019

This should address #131.
Not sure why #128 got closed, and from the look of it #130 isn't providing Symfony 5 support.

@gnugat
Copy link
Contributor Author

gnugat commented Dec 3, 2019

Tests fail due to:

  • PHP 7.2: use of PHPUnit 8 (tests pass with PHPUnit 7)
  • PHP 5.5, 5.4: no longer supported by phpenv (used in Travis)

I recommend dropping older PHP versions, and perhaps upgrading tests to PHPUnit 8 (see #129 to solve both), and even maybe dropping support to older symfony versions (see #130).

@stof
Copy link
Member

stof commented Dec 3, 2019 

* PHP 5.5, 5.4: no longer supported by phpenv (used in Travis)

Actually, they can be supported by forcing dist: trusty (which was the default previously)

@gnugat
Copy link
Contributor Author

gnugat commented Dec 3, 2019

Good news, I managed to fix the PHPUnit BC break (Symfony PHPUnit Bridge allows a SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT=1 environment variable to fix that issue).
Bad news, the dist: trusty doesn't seem to do the trick, although I'm not quite sure why...

derrabus
derrabus suggested changes Dec 3, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@gnugat @derrabus
Removed duplicate PHP 5.5 and 5.4 entries from travis.yml
3dab5b0 
As suggested by @derrabus, PHP 5.5 and 5.4 are also added through the matrix, so they're unnecessary in the php version list.

Co-Authored-By: Alexander M. Turek <me@derrabus.de>
@gnugat
Copy link
Contributor Author

gnugat commented Dec 4, 2019

Bruce Willis threatening: "Green?", Chris Tucker answering "Supergreen" From the movie the 5th Element

@stof stof merged commit 554ac0e into Incenteev:master Dec 10, 2019
@stof stof mentioned this pull request Dec 10, 2019
Closed
@adrienfr
Copy link

Hi, do you know when a release can be expected to enjoy the SF5 compatibility ? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gnugat @stof @adrienfr @derrabus