New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental Apple Silicon (M1) support #1924
Experimental Apple Silicon (M1) support #1924
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1924 +/- ##
========================================
Coverage 97.96% 97.96%
========================================
Files 109 109
Lines 6351 6352 +1
========================================
+ Hits 6222 6223 +1
Misses 129 129
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. It's been on our TODO list for a while, but I don't have access to a mac , so I've not been able to do it myself.
IIUC, github actions will be (or maybe already has) introducing support for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you do a pull from develop to get this up-to-date?
FWIW, I don't think there will be support for GH hosted |
PR type: enhancement
Related issue(s)/PRs: Contributes to #1850
Summary
Proposed changes
This PR introduces basic support for Apple Silicon MacOS. This is achieved by pulling
tensorflow-macos
dependency instead of regulartensorflow
at setup time.This has been tested on an Macbook Pro 2021 M1 Pro,
python3.8
.setup.py
to dynamically decide on thetensorflow
source depending on the platformgpflow/utilities/traversal.py
andtest_traversal.py
come from the common type of errors that0.999999 != 1.0
and representation of floating point numbers.What alternatives have you considered?
No alternatives have been considered. Please let me know if there are any.
Minimal working example
Known problems
With
python3.8
installed viabrew
, integration tests for notebooks sometimes fail withOSError: too many files open
. I think this is a known issue and can be addressed separately.Fully backwards compatible: yes
PR checklist
make format
)make check-all
)