Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Apple Silicon (M1) support #1924

Merged
merged 7 commits into from
Jul 5, 2022
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,5 +83,6 @@ Because GitHub's [graph of contributors](http://github.com/GPflow/GPflow/graphs/
[@jesnie](https://github.com/jesnie)
[@tmct](https://github.com/tmct)
[@ltiao](https://github.com/ltiao)
[@corwinpro](https://github.com/corwinpro)

Add yourself when you first contribute to GPflow's code, tests, or documentation!
3 changes: 2 additions & 1 deletion RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,13 @@ This release contains contributions from:
* <SIMILAR TO ABOVE SECTION, BUT FOR OTHER IMPORTANT CHANGES / BUG FIXES>
* <IF A CHANGE CLOSES A GITHUB ISSUE, IT SHOULD BE DOCUMENTED HERE>
* <NOTES SHOULD BE GROUPED PER AREA>
* Add support for Apple Silicon Macs (`arm64`) via the `tensorflow-macos` dependency. (#1850)

## Thanks to our Contributors

This release contains contributions from:

jesnie
jesnie, corwinpro


# Release 2.5.2
Expand Down
3 changes: 2 additions & 1 deletion gpflow/utilities/traversal.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from functools import lru_cache
from typing import Any, Callable, Dict, Mapping, Optional, Pattern, Tuple, Type, TypeVar, Union

import numpy as np
import tensorflow as tf
import tensorflow_probability as tfp
from packaging.version import Version
Expand Down Expand Up @@ -330,7 +331,7 @@ def _first_three_elements_regexp() -> Pattern[str]:


def _str_tensor_value(value: AnyNDArray) -> str:
value_str = str(value)
value_str = str(np.around(value, 5))
jesnie marked this conversation as resolved.
Show resolved Hide resolved
if value.size <= 3:
return value_str

Expand Down
4 changes: 3 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
"setuptools>=41.0.0", # to satisfy dependency constraints
"tabulate",
"tensorflow-probability>=0.12.0",
"tensorflow>=2.4.0",
"tensorflow>=2.4.0; platform_system!='Darwin' or platform_machine!='arm64'",
# NOTE: Support of Apple Silicon MacOS platforms is in an experimental mode
"tensorflow-macos>=2.4.0; platform_system=='Darwin' and platform_machine=='arm64'",
# NOTE: once we require tensorflow-probability>=0.12, we can remove our custom deepcopy handling
"typing_extensions",
]
Expand Down
4 changes: 2 additions & 2 deletions tests/gpflow/utilities/test_traversal.py
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def test_leaf_components_registers_variable_properties(
for path, variable in leaf_components(module).items():
param_name = path.split(".")[-2] + "." + path.split(".")[-1]
assert isinstance(variable, gpflow.Parameter)
np.testing.assert_equal(variable.numpy(), expected_param_dicts[param_name]["value"])
np.testing.assert_almost_equal(variable.numpy(), expected_param_dicts[param_name]["value"])
assert variable.trainable == expected_param_dicts[param_name]["trainable"]
assert variable.shape == expected_param_dicts[param_name]["shape"]

Expand All @@ -349,7 +349,7 @@ def test_leaf_components_registers_compose_kernel_variable_properties(
path_as_list = path.split(".")
param_name = path_as_list[-3] + "." + path_as_list[-2] + "." + path_as_list[-1]
assert isinstance(variable, gpflow.Parameter)
np.testing.assert_equal(variable.numpy(), expected_param_dicts[param_name]["value"])
np.testing.assert_almost_equal(variable.numpy(), expected_param_dicts[param_name]["value"])
assert variable.trainable == expected_param_dicts[param_name]["trainable"]
assert variable.shape == expected_param_dicts[param_name]["shape"]

Expand Down