Don't round small values in print summary #2093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR type: bugfix
Related issue(s)/PRs:
Summary
Proposed changes
PR #1924 resulted in values in print summary being truncated to 5 decimal places, which is a problem for eg small variances. This PR prevents rounding for values less than 1.
What alternatives have you considered?
Arguably any rounding is unnecessary. However, the print summary tests currently have hardcoded expecations and fail when run on MacOS if the values aren't rounded. Since the values are meant to be human readable there is no harm in rounding large values.
Release notes
Fully backwards compatible: yes
If not, why is it worth breaking backwards compatibility:
PR checklist
make format
)make check-all
)