Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsNullFixer - fix parenthesis not closed #4229

Merged
merged 1 commit into from Jan 4, 2019
Merged

IsNullFixer - fix parenthesis not closed #4229

merged 1 commit into from Jan 4, 2019

Conversation

guilliamxavier
Copy link
Contributor

Includes and fixes #4225

@guilliamxavier guilliamxavier mentioned this pull request Jan 3, 2019
Merged
@SpacePossum SpacePossum mentioned this pull request Jan 3, 2019
Closed
@SpacePossum SpacePossum added this to the 2.12.6 milestone Jan 3, 2019
@SpacePossum
Copy link
Contributor

Sorry that you run into these bugs, great that you opened PR's to prove the issues and proposed fixes as well 👍 I hope we can review and test soon!
Thanks so much @guilliamxavier :)

@keradus keradus mentioned this pull request Jan 4, 2019
Closed
20 tasks
keradus
keradus approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking awesome, @guilliamxavier !

@keradus
Copy link
Member

keradus commented Jan 4, 2019

Thank you @guilliamxavier.

@keradus keradus merged commit 83944b8 into PHP-CS-Fixer:2.12 Jan 4, 2019
keradus added a commit that referenced this pull request Jan 4, 2019
@keradus
bug #4229 IsNullFixer - fix parenthesis not closed (guilliamxavier)
1afc836 
This PR was merged into the 2.12 branch.

Discussion
----------

IsNullFixer - fix parenthesis not closed

Includes and fixes #4225

Commits
-------

83944b8 IsNullFixer - fix parenthesis not closed
keradus added a commit that referenced this pull request Jan 4, 2019
@keradus
minor #4230 [7.3] IsNullFixer - fix trailing comma (guilliamxavier)
75797f6 
This PR was merged into the 2.12 branch.

Discussion
----------

[7.3] IsNullFixer - fix trailing comma

Includes and fixes #4226

I also had to include #4229 first

Commits
-------

31e0d12 [7.3] IsNullFixer - fix trailing comma
@guilliamxavier guilliamxavier deleted the fix-is_null branch January 4, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
2.12.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guilliamxavier @SpacePossum @keradus