Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.3] IsNullFixer - fix trailing comma #4230

Merged
merged 1 commit into from
Jan 4, 2019
Merged

[7.3] IsNullFixer - fix trailing comma #4230

merged 1 commit into from
Jan 4, 2019

Conversation

guilliamxavier
Copy link
Contributor

@guilliamxavier guilliamxavier commented Jan 3, 2019 •
edited

Includes and fixes #4226

I also had to include #4229 first

@SpacePossum SpacePossum mentioned this pull request Jan 3, 2019
Closed
@SpacePossum SpacePossum added this to the 2.12.6 milestone Jan 3, 2019
@keradus keradus mentioned this pull request Jan 4, 2019
Closed
20 tasks
keradus
keradus approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when CI are green

@keradus
Copy link
Member

keradus commented Jan 4, 2019

Thank you @guilliamxavier.

@keradus keradus merged commit 31e0d12 into PHP-CS-Fixer:2.12 Jan 4, 2019
keradus added a commit that referenced this pull request Jan 4, 2019
@keradus
minor #4230 [7.3] IsNullFixer - fix trailing comma (guilliamxavier)
75797f6 
This PR was merged into the 2.12 branch.

Discussion
----------

[7.3] IsNullFixer - fix trailing comma

Includes and fixes #4226

I also had to include #4229 first

Commits
-------

31e0d12 [7.3] IsNullFixer - fix trailing comma
@guilliamxavier guilliamxavier deleted the fix-is_null-php73 branch January 4, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
2.12.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guilliamxavier @keradus @SpacePossum