Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsNullFixer - failing test: parenthesis not closed #4225

Closed
wants to merge 1 commit into from
Closed

IsNullFixer - failing test: parenthesis not closed #4225

wants to merge 1 commit into from

Conversation

guilliamxavier
Copy link
Contributor

Refs #2653

@guilliamxavier guilliamxavier mentioned this pull request Jan 3, 2019
Closed
@SpacePossum SpacePossum added this to the 2.12.6 milestone Jan 3, 2019
@SpacePossum SpacePossum added the WIP label Jan 3, 2019
@guilliamxavier guilliamxavier changed the title IsNullFixer - failing test: parenthese not closed IsNullFixer - failing test: parenthesis not closed Jan 3, 2019
This was referenced Jan 3, 2019
Merged
Merged
@SpacePossum
Copy link
Contributor

closing in favor of #4229 which has the same tests but also a fix proposal :)

@SpacePossum SpacePossum closed this Jan 3, 2019
@keradus keradus removed this from the 2.12.6 milestone Jan 4, 2019
keradus added a commit that referenced this pull request Jan 4, 2019
@keradus
bug #4229 IsNullFixer - fix parenthesis not closed (guilliamxavier)
1afc836 
This PR was merged into the 2.12 branch.

Discussion
----------

IsNullFixer - fix parenthesis not closed

Includes and fixes #4225

Commits
-------

83944b8 IsNullFixer - fix parenthesis not closed
@guilliamxavier guilliamxavier deleted the failing-is_null branch January 4, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guilliamxavier @SpacePossum @keradus