minor #4230 [7.3] IsNullFixer - fix trailing comma (guilliamxavier)

This PR was merged into the 2.12 branch. Discussion ---------- [7.3] IsNullFixer - fix trailing comma Includes and fixes #4226 I also had to include #4229 first Commits ------- 31e0d12 [7.3] IsNullFixer - fix trailing comma
PHP-CS-Fixer · Jan 4, 2019 · 75797f6 · 75797f6
2 parents cb243a9 + 31e0d12
commit 75797f6
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 5 deletions.
diff --git a/src/Fixer/LanguageConstruct/IsNullFixer.php b/src/Fixer/LanguageConstruct/IsNullFixer.php
@@ -136,12 +136,14 @@ protected function applyFix(\SplFileInfo $file, Tokens $tokens)
             $parentOperations = [T_IS_EQUAL, T_IS_NOT_EQUAL, T_IS_IDENTICAL, T_IS_NOT_IDENTICAL];
             $wrapIntoParentheses = $parentLeftToken->isGivenKind($parentOperations) || $parentRightToken->isGivenKind($parentOperations);
 
+            // possible trailing comma removed
+            $prevIndex = $tokens->getPrevMeaningfulToken($referenceEnd);
+            if ($tokens[$prevIndex]->equals(',')) {
+                $tokens->clearTokenAndMergeSurroundingWhitespace($prevIndex);
+            }
+
             if (!$isContainingDangerousConstructs) {
                 // closing parenthesis removed with leading spaces
-                $prevIndex = $tokens->getPrevMeaningfulToken($referenceEnd);
-                if ($tokens[$prevIndex]->equals(',')) {
-                    $tokens->clearTokenAndMergeSurroundingWhitespace($prevIndex);
-                }
                 $tokens->removeLeadingWhitespace($referenceEnd);
                 $tokens->clearAt($referenceEnd);
 

diff --git a/tests/Fixer/LanguageConstruct/IsNullFixerTest.php b/tests/Fixer/LanguageConstruct/IsNullFixerTest.php
@@ -224,7 +224,7 @@ public function provideFixCases()
                 '<?php if ((is_null($u) or $v) and ($w || is_null($x)) xor (!is_null($y) and $z)) echo "foo"; ?>',
             ],
 
-            // edge cases: contains dangerous constructs, wrapped into parentheses
+            // edge cases: $isContainingDangerousConstructs, $wrapIntoParentheses
             [
                 '<?php null === ($a ? $x : $y);',
                 '<?php is_null($a ? $x : $y);',
@@ -311,6 +311,20 @@ public function provideFix73Cases()
                 '<?php if ((null === $u or $v) and ($w || null === $x) xor (null !== $y and $z)) echo "foo"; ?>',
                 '<?php if ((is_null($u, ) or $v) and ($w || is_null($x, )) xor (!is_null($y, ) and $z)) echo "foo"; ?>',
             ],
+
+            // edge cases: $isContainingDangerousConstructs, $wrapIntoParentheses
+            [
+                '<?php null === ($a ? $x : $y );',
+                '<?php is_null($a ? $x : $y, );',
+            ],
+            [
+                '<?php $a === (null === $x);',
+                '<?php $a === is_null($x, );',
+            ],
+            [
+                '<?php $a === (null === ($a ? $x : $y ));',
+                '<?php $a === is_null($a ? $x : $y, );',
+            ],
         ];
     }
 }