Move init of default XStream Serializer to the init()-Method #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # axon-server-connector/pom.xml # config/pom.xml # disruptor/pom.xml # eventsourcing/pom.xml # integrationtests/pom.xml # legacy/pom.xml # messaging/pom.xml # metrics-micrometer/pom.xml # metrics/pom.xml # modelling/pom.xml # pom.xml # spring-boot-autoconfigure/pom.xml # spring-boot-starter/pom.xml # spring/pom.xml # test/pom.xml
Bumps `byte-buddy.version` from 1.11.7 to 1.11.8. Updates `byte-buddy` from 1.11.7 to 1.11.8 - [Release notes](https://github.com/raphw/byte-buddy/releases) - [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md) - [Commits](raphw/byte-buddy@byte-buddy-1.11.7...byte-buddy-1.11.8) Updates `byte-buddy-agent` from 1.11.7 to 1.11.8 - [Release notes](https://github.com/raphw/byte-buddy/releases) - [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md) - [Commits](raphw/byte-buddy@byte-buddy-1.11.7...byte-buddy-1.11.8) --- updated-dependencies: - dependency-name: net.bytebuddy:byte-buddy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: net.bytebuddy:byte-buddy-agent dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…aven/byte-buddy.version-1.11.8 Bump byte-buddy.version from 1.11.7 to 1.11.8
Update spring version from 5.3.5 to 5.3.9
Add patch updates to the main dependabot.yml. Apparently dependabot only checks for the base branch, where they're not planning to change this either - dependabot/dependabot-core#2159 Hence, let's add it to the main dependabot file
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.20 to 42.2.23. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/REL42.2.23/CHANGELOG.md) - [Commits](pgjdbc/pgjdbc@REL42.2.20...REL42.2.23) --- updated-dependencies: - dependency-name: org.postgresql:postgresql dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps `slf4j.version` from 1.7.30 to 1.7.31. Updates `jul-to-slf4j` from 1.7.30 to 1.7.31 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](qos-ch/slf4j@v_1.7.30...v_1.7.31) Updates `jcl-over-slf4j` from 1.7.30 to 1.7.31 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](qos-ch/slf4j@v_1.7.30...v_1.7.31) Updates `slf4j-api` from 1.7.30 to 1.7.31 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](qos-ch/slf4j@v_1.7.30...v_1.7.31) --- updated-dependencies: - dependency-name: org.slf4j:jul-to-slf4j dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: org.slf4j:jcl-over-slf4j dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [metrics-core](https://github.com/dropwizard/metrics) from 4.1.18 to 4.1.24. - [Release notes](https://github.com/dropwizard/metrics/releases) - [Commits](dropwizard/metrics@v4.1.18...v4.1.24) --- updated-dependencies: - dependency-name: io.dropwizard.metrics:metrics-core dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps `spring.boot.version` from 2.4.4 to 2.4.8. Updates `spring-boot-configuration-processor` from 2.4.4 to 2.4.8 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.4.4...v2.4.8) Updates `spring-boot-starter` from 2.4.4 to 2.4.8 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.4.4...v2.4.8) Updates `spring-boot-autoconfigure-processor` from 2.4.4 to 2.4.8 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.4.4...v2.4.8) Updates `spring-boot-starter-data-jpa` from 2.4.4 to 2.4.8 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.4.4...v2.4.8) Updates `spring-boot-starter-test` from 2.4.4 to 2.4.8 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.4.4...v2.4.8) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-configuration-processor dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-starter dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-autoconfigure-processor dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-starter-data-jpa dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-starter-test dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps `testcontainers.version` from 1.15.2 to 1.15.3. Updates `junit-jupiter` from 1.15.2 to 1.15.3 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.15.2...1.15.3) Updates `mysql` from 1.15.2 to 1.15.3 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.15.2...1.15.3) Updates `oracle-xe` from 1.15.2 to 1.15.3 - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.15.2...1.15.3) --- updated-dependencies: - dependency-name: org.testcontainers:junit-jupiter dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.testcontainers:mysql dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: org.testcontainers:oracle-xe dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…aven/axon-4.5.x/org.postgresql-postgresql-42.2.23 Bump postgresql from 42.2.20 to 42.2.23
…aven/axon-4.5.x/slf4j.version-1.7.31 Bump slf4j.version from 1.7.30 to 1.7.31
…aven/axon-4.5.x/io.dropwizard.metrics-metrics-core-4.1.24 Bump metrics-core from 4.1.18 to 4.1.24
…aven/axon-4.5.x/spring.boot.version-2.4.8 Bump spring.boot.version from 2.4.4 to 2.4.8
…aven/axon-4.5.x/testcontainers.version-1.15.3 Bump testcontainers.version from 1.15.2 to 1.15.3
Bumps [metrics-core](https://github.com/dropwizard/metrics) from 4.2.2 to 4.2.3. - [Release notes](https://github.com/dropwizard/metrics/releases) - [Commits](dropwizard/metrics@v4.2.2...v4.2.3) --- updated-dependencies: - dependency-name: io.dropwizard.metrics:metrics-core dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [hibernate-entitymanager](https://github.com/hibernate/hibernate-orm) from 5.4.30.Final to 5.4.32.Final. - [Release notes](https://github.com/hibernate/hibernate-orm/releases) - [Changelog](https://github.com/hibernate/hibernate-orm/blob/5.4.32/changelog.txt) - [Commits](hibernate/hibernate-orm@5.4.30...5.4.32) --- updated-dependencies: - dependency-name: org.hibernate:hibernate-entitymanager dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [spring-security-bom](https://github.com/spring-projects/spring-security) from 5.4.5 to 5.4.7. - [Release notes](https://github.com/spring-projects/spring-security/releases) - [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc) - [Commits](spring-projects/spring-security@5.4.5...5.4.7) --- updated-dependencies: - dependency-name: org.springframework.security:spring-security-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps `projectreactor.version` from 3.4.4 to 3.4.8. Updates `reactor-core` from 3.4.4 to 3.4.8 - [Release notes](https://github.com/reactor/reactor-core/releases) - [Commits](reactor/reactor-core@v3.4.4...v3.4.8) Updates `reactor-test` from 3.4.4 to 3.4.8 - [Release notes](https://github.com/reactor/reactor-core/releases) - [Commits](reactor/reactor-core@v3.4.4...v3.4.8) --- updated-dependencies: - dependency-name: io.projectreactor:reactor-core dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.projectreactor:reactor-test dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [junit-jupiter](https://github.com/junit-team/junit5) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.7.1...r5.7.2) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [metrics-core](https://github.com/dropwizard/metrics) from 4.1.24 to 4.1.25. - [Release notes](https://github.com/dropwizard/metrics/releases) - [Commits](dropwizard/metrics@v4.1.24...v4.1.25) --- updated-dependencies: - dependency-name: io.dropwizard.metrics:metrics-core dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…aven/axon-4.5.x/org.springframework.security-spring-security-bom-5.4.7 Bump spring-security-bom from 5.4.5 to 5.4.7
…aven/axon-4.5.x/io.dropwizard.metrics-metrics-core-4.1.25 Bump metrics-core from 4.1.24 to 4.1.25
…aven/io.dropwizard.metrics-metrics-core-4.2.3 Bump metrics-core from 4.2.2 to 4.2.3
…aven/axon-4.5.x/projectreactor.version-3.4.8 Bump projectreactor.version from 3.4.4 to 3.4.8
…aven/axon-4.5.x/org.junit.jupiter-junit-jupiter-5.7.2 Bump junit-jupiter from 5.7.1 to 5.7.2
…r in the init()-Method so XStream can be excluded from the dependencies
|
|
|
@smcvb The fix is done but sonar in JDK 11 failed. I would guess this is a permission problem? |
@mvonrenteln I've trigerred the build myself but it is likely a permission problem like you said. Anyway, thank you for the PR! |
lfgcampos
added
Priority 2: Should
smcvb
added
Priority 3: Could
smcvb
requested changes
Sep 23, 2021
There was a problem hiding this comment.
Change-wise, this looks fine, but I still have a request. It would be nice to add this to 4.5.4 of Axon Framework (as was marked by @lfgcampos too with the milestone). To add it to 4.5.4, however, requires this pull request to be merged with the axon-4.5.x branch. Would you mind, @mvonrenteln, changing the base of this pull request to that branch?
|
If I change the base brach, many changes will be pulled in. I will supply a new, clean branch... |
mvonrenteln
deleted the
feature/issue-1931-remove-xstream-requirement
branch
smcvb
added
Status: Obsolete
|
Thanks for the effort @mvonrenteln 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1931
XStream-Dependency was hard coded therefore it could not be excluded. Now it is initialized lazy if no serializer was provided.