Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on XStream, even when not using any XStream serializers #1931

Closed
athurm opened this issue Sep 20, 2021 · 4 comments
Closed

Dependency on XStream, even when not using any XStream serializers #1931

athurm opened this issue Sep 20, 2021 · 4 comments
Assignees
Labels
Ideal for Contribution Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Enhancement Use to signal an issue enhances an already existing feature of the project.
Milestone

Comments

@athurm
Copy link

athurm commented Sep 20, 2021

It's currently not possible to use Axon without XStream getting configured, even when XStream is not used for any serializers.

<dependency>
    <groupId>org.axonframework</groupId>
    <artifactId>axon-messaging</artifactId>
    <version>${version.axon}</version>
    <exclusions>
        <exclusion>
            <groupId>com.thoughtworks.xstream</groupId>
            <artifactId>xstream</artifactId>
        </exclusion>
    </exclusions>
</dependency>

JpaSagaStore:361

private Supplier serializer = XStreamSerializer::defaultSerializer;

Caused by: java.lang.NoClassDefFoundError: com/thoughtworks/xstream/mapper/CannotResolveClassException
at deployment.war//org.axonframework.modelling.saga.repository.jpa.JpaSagaStore$Builder.>(JpaSagaStore.java:361)

Same Issue was with QuartzEventScheduler :
Axon 4.5
[#1685] Remove QuartzEventScheduler hard dependency on XStream #1690
Remove hard dependency on XStream in QuartzEventScheduler #1685

@athurm athurm added the Type: Bug Use to signal issues that describe a bug within the system. label Sep 20, 2021
@mvonrenteln
Copy link
Contributor

I'll provide a pull request for this issue.

@mvonrenteln
Copy link
Contributor

The Change would be like in https://github.com/AxonFramework/AxonFramework/pull/1440/files

mvonrenteln added a commit to mvonrenteln/AxonFramework that referenced this issue Sep 21, 2021
…r in the init()-Method so XStream can be excluded from the dependencies
@lfgcampos lfgcampos added Ideal for Contribution Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Status: In Progress Use to signal this issue is actively worked on. labels Sep 22, 2021
@lfgcampos lfgcampos added this to the Release 4.5.4 milestone Sep 22, 2021
@mvonrenteln
Copy link
Contributor

@smcvb A fix is provided in #1932

@smcvb smcvb added Type: Enhancement Use to signal an issue enhances an already existing feature of the project. and removed Type: Bug Use to signal issues that describe a bug within the system. labels Sep 23, 2021
@smcvb
Copy link
Member

smcvb commented Sep 23, 2021

I've changed the type from "bug" to "enhancement," as I wouldn't describe this as a framework bug at this stage.

Of course, it is not ideal, hence why a pull request is warranted.
From that end, thanks for the effort, @mvonrenteln!

I'll take a look ASAP.

@smcvb smcvb added Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. and removed Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. labels Sep 23, 2021
mvonrenteln added a commit to mvonrenteln/AxonFramework that referenced this issue Sep 28, 2021
…r in the init()-Method so XStream can be excluded from the dependencies
@close-label close-label bot added the Status: Resolved Use to signal that work on this issue is done. label Sep 29, 2021
@athurm athurm closed this as completed Sep 29, 2021
@smcvb smcvb removed the Status: In Progress Use to signal this issue is actively worked on. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ideal for Contribution Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Enhancement Use to signal an issue enhances an already existing feature of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants