Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move init of default XStream Serializer to the init()-Method #1957

Conversation

mvonrenteln
Copy link
Contributor

Fixes #1931
Supersedes #1932
XStream-Dependency was hard coded therefore it could not be excluded. Now it is initialized lazy if no serializer was provided.

Based on Axon 4.5.x

@mvonrenteln
Copy link
Contributor Author

@smcvb @lfgcampos Replacement for #1932

…r in the init()-Method so XStream can be excluded from the dependencies
@smcvb smcvb added Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: In Progress Use to signal this issue is actively worked on. Type: Enhancement Use to signal an issue enhances an already existing feature of the project. labels Sep 29, 2021
@smcvb smcvb added this to the Release 4.5.4 milestone Sep 29, 2021
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb
Copy link
Member

smcvb commented Sep 29, 2021

Ignoring the JDK 11 build, since that requires Sonar authentication missing for contributors.

@smcvb smcvb merged commit 306f0b1 into AxonFramework:axon-4.5.x Sep 29, 2021
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Sep 29, 2021
@mvonrenteln mvonrenteln deleted the feature/issue-1931-remove-xstream-requirement-45 branch September 29, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Enhancement Use to signal an issue enhances an already existing feature of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants