refactor(coral): Add DYNAMIC_API_PATHS #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Anderson <mathieu.anderson@aiven.io>
mathieu-anderson
added
Housekeeping
mathieu-anderson
force-pushed
the
1446-dynamic-api-paths
branch
from
0672e86
to
6ca9251
Compare
added 2 commits
July 18, 2023 16:12
Signed-off-by: Mathieu Anderson <mathieu.anderson@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Separate the API paths with dynamic parts into
DYNAMIC_API_PATHS, which holds functions returning interpolated values for the dynamic parts of the pathResolves: #1446
CI failure
The CI fails because the current version of
prettierdoesn't recognize thesatisfiessyntax. It will be fixed after this is merged: #1481