Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update strategy for type-safety in api calls #1021

Closed
programmiri opened this issue Apr 12, 2023 · 1 comment
Closed

refactor: Update strategy for type-safety in api calls #1021

programmiri opened this issue Apr 12, 2023 · 1 comment
Labels
Frontend Relates to coral (react app) Housekeeping Task for undefined date

Comments

@programmiri
Copy link
Contributor

programmiri commented Apr 12, 2023 •
edited

See this comment: https://github.com/aiven/klaw/pull/1018/files#r1163684641

Also, with our current api client / api maps we can't handle paths that require their param in pathname (not in query), e.g. /user/{userId}/switchTeamsList
@programmiri programmiri added Housekeeping Task for undefined date Frontend Relates to coral (react app) labels Apr 12, 2023
@programmiri programmiri changed the title refactor: Better strategy for type-safety in api calls refactor: Update strategy for type-safety in api calls Apr 27, 2023
@programmiri programmiri mentioned this issue May 10, 2023
Closed
@mathieu-anderson
Copy link
Contributor

I think the issue raised in the description has been addressed by #1480

Closing, but do not hesitate to re-open if it was a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Frontend Relates to coral (react app) Housekeeping Task for undefined date
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@programmiri @mathieu-anderson