Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping(coral): Upgrade prettier to 3.0.0 #1481

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Conversation

mathieu-anderson
Copy link
Contributor

@mathieu-anderson mathieu-anderson commented Jul 18, 2023

About this change - What it does

This PR also upgrade prettier to version 3.0.0, as our current version did not support the satisfies syntax needed for this PR: #1480

However, given that 3.0.0 is a breaking change which has all as the default value for trailingComma, this PR also adds a .prettierc file to keep the es5 behaviour. There were also some small changes bug fixes which required running prettier --write on the codebase to add missing semicolons and parenthesis: 0672e86

@mathieu-anderson mathieu-anderson requested a review from a team as a code owner July 18, 2023 12:57
@mathieu-anderson mathieu-anderson self-assigned this Jul 18, 2023
@mathieu-anderson mathieu-anderson added Housekeeping Task for undefined date Frontend Relates to coral (react app) labels Jul 18, 2023
Mathieu Anderson added 2 commits July 18, 2023 15:02
Signed-off-by: Mathieu Anderson <mathieu.anderson@aiven.io>
Signed-off-by: Mathieu Anderson <mathieu.anderson@aiven.io>
Signed-off-by: Mathieu Anderson <mathieu.anderson@aiven.io>
Copy link
Contributor

@programmiri programmiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹✨🙏

@programmiri programmiri merged commit ee3f0f4 into main Jul 18, 2023
15 checks passed
@programmiri programmiri deleted the update-prettier-3 branch July 18, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Relates to coral (react app) Housekeeping Task for undefined date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants