Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade Ava to 4.2 #5201

Closed
wants to merge 9 commits into from
Closed

chore(deps): upgrade Ava to 4.2 #5201

wants to merge 9 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Apr 22, 2022

@turadg
Copy link
Member Author

turadg commented Apr 26, 2022

Last hurdle here seems to be this error in integration tests with dapps,

  Uncaught exception in test/test-contract.js

  AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: The expression evaluated to a falsy value:

    assert(refs.runnerChain)

which seems to be avajs/ava#2946 (comment)

@kriskowal any ideas?

@kriskowal
Copy link
Member

This does indeed look like the same problem others are having on the new versions of AVA. It doesn’t seem to be interference with hardened JavaScript and it’s hard to imagine it being related to the other things we’ve seen where VS Code debugger tampering with the Node.js environment when a debugger is attached. I’m at a loss.

@turadg
Copy link
Member Author

turadg commented Apr 29, 2022

My current hypothesis for the failures are that it's conflicting versions of Ava due to this line in the failing tests:

import { test } from '@agoric/zoe/tools/prepare-test-env-ava.js';

That package (in this PR) is using Ava 4 and the dapps are on Ava 3. I think we need to decouple the Ava versions. cc @michaelfig #5244 may help.

@turadg
Copy link
Member Author

turadg commented Jul 15, 2022

That package (in this PR) is using Ava 4 and the dapps are on Ava 3. I think we need to decouple the Ava versions

One solution may be to make a new @endo/ses-ava-4 wrap that can coexist with the earlier one (for Ava 3). cc @kriskowal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Ava to version 4
2 participants