Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Ava 4.3 #5793

Merged
merged 10 commits into from Aug 4, 2022
Merged

upgrade to Ava 4.3 #5793

merged 10 commits into from Aug 4, 2022

Conversation

turadg
Copy link
Member

@turadg turadg commented Jul 20, 2022

closes: #4895
supplants: #5201

Description

Upgrade Ava to v4 for the reasons in #4895 and to perhaps help debug #5575 .

Security Considerations

--

Documentation Considerations

Ava version will now match the docs on the Ava repo.

Testing Considerations

A few repo integration tests are breaking due to conflicting versions. Only non-required ones are left and I'll burn those down soon.

@turadg turadg force-pushed the 4895-ava-4.3 branch 3 times, most recently from 945f93e to 63a5077 Compare July 25, 2022 19:52
@turadg turadg force-pushed the 4895-ava-4.3 branch 2 times, most recently from ffcb4c9 to 05168be Compare August 4, 2022 14:30
@turadg turadg marked this pull request as ready for review August 4, 2022 16:08
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all the tests are still passing, this sounds good to me.

@@ -77,7 +77,8 @@
"files": [
"test/**/test-*.js"
],
"timeout": "20m"
"timeout": "20m",
"workerThreads": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this lands, I'd be curious to remove this and see if it affects anything. If "workerThreads" share a JS heap, then we'll probably need to keep it disabled. But maybe they only share a unix process memoryspace, and still have separate instances of the V8 engine (and thus separate JS heaps, so their GC doesn't affect each other), in which case we could use them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I would like to remove this config wherever possible. In my testing these packages failed without this, but maybe we can solve those cases.

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Aug 4, 2022
@mergify mergify bot merged commit cc6836c into master Aug 4, 2022
@mergify mergify bot deleted the 4895-ava-4.3 branch August 4, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Ava to version 4
2 participants