Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate To A Newer Version #20

Closed
anilhelvaci opened this issue Sep 9, 2022 · 1 comment
Closed

Migrate To A Newer Version #20

anilhelvaci opened this issue Sep 9, 2022 · 1 comment

Comments

@anilhelvaci
Copy link
Collaborator

We migrate our code to work on https://github.com/Agoric/agoric-sdk/commit/fedf049435d7307311219fbab1b2b342ec6acce8 this commit

anilhelvaci added a commit that referenced this issue Sep 9, 2022
anilhelvaci added a commit that referenced this issue Sep 9, 2022
…s.js and test-boundaryWatcher.js work and partially migrated test-ammLiquidity.js
@anilhelvaci
Copy link
Collaborator Author

Note to other dapp devs @nunolleite @JorgeLopes-BytePitch

The biggest problem I faced during the migration is to migrate ava from version 3 to version 4. The error I got is something like below;

 Uncaught exception in test/test-stopLoss.js

  AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: The expression evaluated to a falsy value:

    assert(refs.runnerChain)


SES_UNHANDLED_REJECTION: (AssertionError#1)
  ✖ test/test-stopLoss.js exited with a non-zero exit code: 1
  ✖ Couldn’t find any matching tests

And this problem has a closed issue here. Agoric engineering team also faced this issue when they were upgrading ava from v3 to v4 and had an internal issue about it here where they discuss this problem in the context of agoric-sdk. To solve the problem I've followed the steps in this pr where they upgrade dapp-card-store ava version from v3 to v4.

Conclusion

It's a useful thing to keep in mind when we try to migrate dapps from older versions to newer versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant