Multicore improvements #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the clippy errors and warnings; they are being addressed separately. |
daira
reviewed
Jun 1, 2021
daira
reviewed
Jun 1, 2021
daira
reviewed
Jun 1, 2021
daira
reviewed
Jun 1, 2021
daira
reviewed
Jun 1, 2021
daira
reviewed
Jun 1, 2021
| type Item = T; | ||
| type Error = E; | ||
| impl<T> Waiter<T> { | ||
| /// Wait for the result. |
There was a problem hiding this comment.
As far as I can see, this is inaccurate: std::Option::take will never wait.
There was a problem hiding this comment.
It won't, but this is emulating the threaded API. Both instances are effectively blocking, one just blocks for longer.
daira
reviewed
Jun 1, 2021
daira
reviewed
Jun 1, 2021
daira
reviewed
Jun 1, 2021
str4d
commented
Jun 1, 2021
daira
reviewed
Jun 1, 2021
…CPUS (cherry picked from commit 37686f8)
(cherry picked from commit dca4c5a) pick: Only the changes to bellman::multicore.
(cherry picked from commit c55d5e4) Changes during pick: - Excluded GPU-related changes (not upstreamed yet). - Added fix for change to Field::double API. - Fixed no-multicore Worker impl. Co-authored-by: Jack Grigg <thestr4d@gmail.com>
If a waiter is used from within a thread pool it might deadlock. Don't do that. (cherry picked from commit dc13606)
The Worker/Waiter model creates a Worker that requests that threads be spawned to complete some work. Since there is no bound to the number of requests for work, it's possible to exhaust memory with pending closures waiting to be processed. This was not an issue when 'everything was bounded by a single thread pool', however that setup has race conditions built into it. We have recently spent time splitting that model out, and this should be the final step required. This code places a limit on the number of requests that can be queued in an attempt to lessen the chance of memory exhaustion due to pending requests. It does this by placing a limit that is a simple multiple of the number of cores available (and in testing is far below observed crash criteria). When the number of requests for spawning new threads reaches that limit, instead of adding a new request, we block on execution to help clear the backlog. (cherry picked from commit 74947c0) pick: Also includes log change from b481a34
(cherry picked from commit 007487f)
…dpool This occurring is a programming error. Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
|
Rebased on |
daira
reviewed
Aug 15, 2021
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
… is expected to play more nicely with other uses of rayon in the same process (avoiding excess parallelism). Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: str4d <thestr4d@gmail.com>
…icore) implementation. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Use global rayon threadpool for multicore
ebfull
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from https://github.com/filecoin-project/bellperson
Part of #7.
Closes #21.