Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bellman: remove deprecated and unmaintained futures_cpupool #263

Closed
hdevalence opened this issue Aug 5, 2020 · 2 comments
Closed

bellman: remove deprecated and unmaintained futures_cpupool #263

hdevalence opened this issue Aug 5, 2020 · 2 comments

Comments

@hdevalence
Copy link
Contributor

futures_cpupool uses the old-style 0.1 futures that are no longer actively maintained and are not interoperable with the rest of the rust futures ecosystem. It should be removed from bellman.

One option is to continue to use std::future::Future futures. These require an executor. One option is the threadpool from the futures crate, a simple executor which just handles CPU-bound work. Another option is Tokio's blocking threadpool.

Another option would be to deprecate the use of futures and use a synchronous API instead.

Not knowing more about the design of bellman it's hard for me to determine which of the two high-level options is the best.

@hdevalence
Copy link
Contributor Author

Perhaps another option to consider is dropping the multicore / non-multi-core distinction in the bellman code, using Tokio's spawn_blocking unconditionally, and outsourcing the single/multi-threading configuration to the configuration of the Tokio runtime.

@str4d
Copy link
Contributor

str4d commented Jan 31, 2022

Closed by zkcrypto/bellman#69 (which backported the Filecoin changes to migrate bellman to rayon).

@str4d str4d closed this as completed Jan 31, 2022
@r3ld3v r3ld3v added this to the Core Sprint 2022-04 milestone Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants