Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default signature algorithm #606

Merged
merged 2 commits into from May 17, 2024
Merged

feat: add default signature algorithm #606

merged 2 commits into from May 17, 2024

Conversation

nannany
Copy link
Contributor

@nannany nannany commented May 7, 2024

Changed the toJoseSignatureAlgorithms function to support not only RS256 but also ES256 and PS256 when an argument of zero length is given.
See issue #605 for the reason for selecting ES256 and PS256.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@nannany nannany marked this pull request as ready for review May 16, 2024 14:59
@muhlemmer muhlemmer self-requested a review May 17, 2024 09:01
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.04%. Comparing base (0992c5f) to head (46ecf9a).
Report is 61 commits behind head on main.

Current head 46ecf9a differs from pull request most recent head 911d117

Please upload reports for the commit 911d117 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   60.06%   62.04%   +1.98%     
==========================================
  Files          80       81       +1     
  Lines        6998     6192     -806     
==========================================
- Hits         4203     3842     -361     
+ Misses       2498     2041     -457     
- Partials      297      309      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhlemmer muhlemmer changed the title add default signature algorithm feat: add default signature algorithm May 17, 2024
@muhlemmer muhlemmer enabled auto-merge (squash) May 17, 2024 10:16
@muhlemmer muhlemmer merged commit 8a47532 into zitadel:main May 17, 2024
4 checks passed
Copy link

🎉 This PR is included in version 3.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants