Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to increase the defaults for signature algorithm. #605

Closed
2 tasks done
nannany opened this issue May 7, 2024 · 2 comments
Closed
2 tasks done

I want to increase the defaults for signature algorithm. #605

nannany opened this issue May 7, 2024 · 2 comments

Comments

@nannany
Copy link
Contributor

nannany commented May 7, 2024

Preflight Checklist

  • I could not find a solution in the existing issues, docs, nor discussions
  • I have joined the ZITADEL chat

Describe your problem

I am using zitadel/oidc to create an OpenID Provider.
I believe the library intends that the VerifyJWTAssertion function is called when client authentication is done with private_key_jwt.
However, this function currently only supports RS256 since the supportedSigAlgs argument is nil when executing the CheckSignature function.
Therefore I would like to sign with ES256, which is not possible.

Describe your ideal solution

Since the FAPI states that PS256 or ES256 is recommended, why not support PS256 or ES256 if it is not specified here as well?

Version

v3.22.1

Environment

Self-hosted

Additional Context

No response

@hifabienne
Copy link
Member

I think this is a duplicate of the following issue? #259
@muhlemmer @livio-a am I right? In that case I would close the issue here, to avoid duplicates

@muhlemmer
Copy link
Collaborator

closed by #606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants