Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @testing-library/user-event to v13 #1065

Merged
merged 2 commits into from Apr 1, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 29, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@testing-library/user-event 12.7.3 -> 13.1.1 age adoption passing confidence

Release Notes

testing-library/user-event

v13.1.1

Compare Source

Bug Fixes

v13.1.0

Compare Source

Features

v13.0.16

Compare Source

Bug Fixes
  • keyboard: suppress invalid input on <input type="number"> (#​628) (f633a52)

v13.0.15

Compare Source

Bug Fixes

v13.0.14

Compare Source

Bug Fixes

v13.0.13

Compare Source

Bug Fixes

v13.0.12

Compare Source

Bug Fixes

v13.0.11

Compare Source

Bug Fixes

v13.0.10

Compare Source

Bug Fixes

v13.0.9

Compare Source

Bug Fixes
  • keyboard: inputType for Enter on contenteditable (#​614) (2b0632a)

v13.0.8

Compare Source

Bug Fixes

v13.0.7

Compare Source

Bug Fixes

v13.0.6

Compare Source

Bug Fixes

v13.0.5

Compare Source

Bug Fixes

v13.0.4

Compare Source

Bug Fixes

v13.0.3

Compare Source

Bug Fixes

v13.0.2

Compare Source

Bug Fixes

v13.0.1

Compare Source

Bug Fixes

v13.0.0

Compare Source

Features
BREAKING CHANGES
  • userEvent.type features a rewritten implementation shared with the new userEvent.keyboard. This might break code depending on unintended/undocumented behavior of the previous implementation.
  • userEvent.type treats { and [ as special characters.
  • userEvent.type returns no Promise if called without delay.

v12.8.3

Compare Source

Bug Fixes

v12.8.2

Compare Source

Bug Fixes

v12.8.1

Compare Source

Bug Fixes

v12.8.0

Compare Source

Features

v12.7.4

Compare Source

Bug Fixes

Renovate configuration

📅 Schedule: "on Monday every 8 weeks of the year starting on the 5th week" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner March 29, 2021 16:54
@coveralls
Copy link

coveralls commented Mar 29, 2021

Coverage Status

Coverage decreased (-0.02%) to 95.135% when pulling 4cd609b on renovate/testing-library-user-event-13.x into 3adc67d on main.

@renovate renovate bot force-pushed the renovate/testing-library-user-event-13.x branch 5 times, most recently from 0b4f561 to f3bd095 Compare March 30, 2021 23:26
@zendesk-garden zendesk-garden temporarily deployed to staging March 31, 2021 22:43 Inactive
renovate-bot and others added 2 commits March 31, 2021 15:50
It looks like there's a recent addition to user-event that checks the
pointer events of elements. It looks like no pointer events are detected
on divs (but do get detected when pointer-events: auto is explicitly applied).

Further investigation needed to see if user-event introduced a bug

See: https://github.com/testing-library/user-event/blob/7143ae30353e0cc7f8f12e405763eaf2257ef03e/src/utils/misc/hasPointerEvents.ts#L3
@hzhu hzhu force-pushed the renovate/testing-library-user-event-13.x branch from 5511916 to 4cd609b Compare March 31, 2021 22:56
@zendesk-garden zendesk-garden temporarily deployed to staging March 31, 2021 23:26 Inactive
@hzhu
Copy link
Contributor

hzhu commented Apr 1, 2021

PopperJS has pointer-events: none; set on the wrapper upon initial render when the menu is closed. When the menu is opened, pointer-events: none; is removed and the menu is positioned. It looks like this doesn't happen in a JSDOM environment. So, pointer-events: none; is never removed and the postioning top and left remain at 0.

The userEvent.click call is looping through an element and it's parent elements to see if they have pointer events. It only executes a click for elements that have pointer events (source).

The tests may just have to use the fireEvent.click instead of userEvent.click for clicking elements within a PopperJS wrapper.

@hzhu hzhu merged commit 01da49c into main Apr 1, 2021
@hzhu hzhu deleted the renovate/testing-library-user-event-13.x branch April 1, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants