Skip to content

Commit

Permalink
Temporarily use fireEvent on div elements
Browse files Browse the repository at this point in the history
It looks like there's a recent addition to user-event that checks the
pointer events of elements. It looks like no pointer events are detected
on divs (but do get detected when pointer-events: auto is explicitly applied).

Further investigation needed to see if user-event introduced a bug

See: https://github.com/testing-library/user-event/blob/7143ae30353e0cc7f8f12e405763eaf2257ef03e/src/utils/misc/hasPointerEvents.ts#L3
  • Loading branch information
hzhu committed Mar 31, 2021
1 parent f3bd095 commit 5511916
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ describe('Datepicker', () => {
const { getByTestId } = render(<Example value={DEFAULT_DATE} />);

userEvent.click(getByTestId('input'));
userEvent.click(getByTestId('previous-month'));
fireEvent.click(getByTestId('previous-month'));

expect(getByTestId('month-display')).toHaveTextContent('January 2019');
});
Expand All @@ -114,7 +114,7 @@ describe('Datepicker', () => {
const { getByTestId } = render(<Example value={DEFAULT_DATE} />);

userEvent.click(getByTestId('input'));
userEvent.click(getByTestId('next-month'));
fireEvent.click(getByTestId('next-month'));

expect(getByTestId('month-display')).toHaveTextContent('March 2019');
});
Expand All @@ -135,7 +135,7 @@ describe('Datepicker', () => {
);

userEvent.click(getByTestId('input'));
userEvent.click(getAllByTestId('day')[1]);
fireEvent.click(getAllByTestId('day')[1]);

expect(onChangeSpy).toHaveBeenCalledWith(new Date(2019, 0, 28));
});
Expand All @@ -148,7 +148,7 @@ describe('Datepicker', () => {
const input = getByTestId('input');

userEvent.click(input);
userEvent.click(getAllByTestId('day')[1]);
fireEvent.click(getAllByTestId('day')[1]);

expect(input).toHaveValue('January 28, 2019');
});
Expand Down
6 changes: 3 additions & 3 deletions packages/dropdowns/src/elements/Dropdown/Dropdown.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ describe('Dropdown', () => {
);

userEvent.click(getByTestId('trigger'));
userEvent.click(getAllByTestId('item')[0]);
fireEvent.click(getAllByTestId('item')[0]);
expect(onSelectSpy.mock.calls[0][0]).toBe('previous-item');
});

Expand All @@ -183,7 +183,7 @@ describe('Dropdown', () => {
);

userEvent.click(getByTestId('trigger'));
userEvent.click(getAllByTestId('item')[0]);
fireEvent.click(getAllByTestId('item')[0]);
expect(onSelectSpy.mock.calls[0][0]).toStrictEqual(['item-1', 'item-2', 'previous-item']);
});

Expand All @@ -197,7 +197,7 @@ describe('Dropdown', () => {
);

userEvent.click(getByTestId('trigger'));
userEvent.click(getAllByTestId('item')[0]);
fireEvent.click(getAllByTestId('item')[0]);
expect(onSelectSpy.mock.calls[0][0]).toStrictEqual(['item-1', 'item-2']);
});

Expand Down
4 changes: 2 additions & 2 deletions packages/dropdowns/src/elements/Menu/Items/AddItem.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import React from 'react';
import userEvent from '@testing-library/user-event';
import { render } from 'garden-test-utils';
import { render, fireEvent } from 'garden-test-utils';
import { Dropdown, Trigger, Menu, AddItem } from '../../..';

describe('AddItem', () => {
Expand All @@ -28,7 +28,7 @@ describe('AddItem', () => {
);

userEvent.click(getByTestId('trigger'));
userEvent.click(getByTestId('add-item'));
fireEvent.click(getByTestId('add-item'));

expect(onSelectSpy.mock.calls[0][0]).toBe('add-item');
});
Expand Down
4 changes: 2 additions & 2 deletions packages/dropdowns/src/elements/Menu/Items/MediaItem.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import React from 'react';
import userEvent from '@testing-library/user-event';
import { render } from 'garden-test-utils';
import { render, fireEvent } from 'garden-test-utils';
import { Dropdown, Trigger, Menu, MediaItem } from '../../..';

describe('MediaItem', () => {
Expand All @@ -28,7 +28,7 @@ describe('MediaItem', () => {
);

userEvent.click(getByTestId('trigger'));
userEvent.click(getByTestId('media-item'));
fireEvent.click(getByTestId('media-item'));

expect(onSelectSpy.mock.calls[0][0]).toBe('media-item');
});
Expand Down

0 comments on commit 5511916

Please sign in to comment.