Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo causing a panic in tuple unification #126

Merged
merged 1 commit into from Jun 23, 2022
Merged

fix typo causing a panic in tuple unification #126

merged 1 commit into from Jun 23, 2022

Commits on Jun 22, 2022

  1. fix typo causing a panic in tuple unification 

    The `unifyObjectTypesToMap` function was inadvertently called from the
tuple-list unification function, which would panic since the value has
no attributes.

The given test example is possible speculatively unify, however we don't
have a codepath to recursively unify these yet, so we will just fail to
unify for now. This will fix the crashes in downstream consumers,
allowing the possibility of working around the shortcoming by using more
specific or different combinations of types.
    @jbardin
    jbardin committed Jun 22, 2022
    Copy the full SHA
    749e37b View commit details
    Browse the repository at this point in the history