fix typo causing a panic in tuple unification #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `unifyObjectTypesToMap` function was inadvertently called from the tuple-list unification function, which would panic since the value has no attributes. The given test example is possible speculatively unify, however we don't have a codepath to recursively unify these yet, so we will just fail to unify for now. This will fix the crashes in downstream consumers, allowing the possibility of working around the shortcoming by using more specific or different combinations of types.
|
Thanks! This makes sense to me... always "fun" when a panic is reached via a "should never get here" codepath. 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unifyObjectTypesToMapfunction was inadvertently called from the tuple-list unification function, which would panic since the value has no attributes.The given test example is possible to speculatively unify, however we don't have a codepath to recursively unify these yet, so we will just fail to unify for now. This will fix the crashes in downstream consumers, allowing the possibility of working around the shortcoming by using more specific or different combinations of types.