Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function/stdlib: Fix setproduct bug with unknowns #109

Merged

Commits on Jun 21, 2021

  1. function/stdlib: Fix setproduct bug with unknowns

    If an argument to setproduct is a set with unknown values, its length is
    unknown, as the unknown values may be duplicates of others in the set.
    This should result in returning an unknown value propagating all marks.
    
    Previously this crashed due to a misuse of `.Mark(marks)` instead of
    `.WithMarks(marks)`. This commit also fixes an issue with the previous
    logic, which would shortcut return and omit marks from any arguments
    after the set with unknown length.
    
    Also includes a couple of tests for setproduct that were in my local
    working copy for some reason.
    alisdair committed Jun 21, 2021
    Copy the full SHA
    0cc36e7 View commit details
    Browse the repository at this point in the history