function/stdlib: Fix setproduct bug with unknowns #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an argument to setproduct is a set with unknown values, its length is unknown, as the unknown values may be duplicates of others in the set. This should result in returning an unknown value propagating all marks. Previously this crashed due to a misuse of `.Mark(marks)` instead of `.WithMarks(marks)`. This commit also fixes an issue with the previous logic, which would shortcut return and omit marks from any arguments after the set with unknown length. Also includes a couple of tests for setproduct that were in my local working copy for some reason.
|
This looks great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an argument to
setproductis a set with unknown values, its length is unknown, as the unknown values may be duplicates of others in the set. This should result in returning an unknown value propagating all marks.Previously this crashed due to a misuse of
.Mark(marks)instead of.WithMarks(marks). This commit also fixes an issue with the previous logic, which would shortcut return and omit marks from any arguments after the set with unknown length.Also includes a couple of tests for setproduct that were in my local working copy for some reason.
Downstream issue: hashicorp/terraform#28984