[ZIP 216] Add "Retroactive applicability" section and clarify that the zero point is not valid for pk_d #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
force-pushed
the
zip216-retroactive
branch
6 times, most recently
from
569b2fc
to
de87551
Compare
daira
commented
Feb 8, 2023
str4d
reviewed
Feb 8, 2023
daira
commented
Feb 8, 2023
daira
commented
Feb 8, 2023
dconnolly
approved these changes
Feb 8, 2023
dconnolly
approved these changes
Feb 15, 2023
str4d
approved these changes
Feb 15, 2023
zero point is not valid for pk_d. Also correct the omission of the nk field of a Sapling full or extended full viewing key. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
daira
force-pushed
the
zip216-retroactive
branch
from
a25b240
to
43d6e9a
Compare
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org> Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
daira
changed the title
daira
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #671
Signed-off-by: Daira Hopwood daira@jacaranda.org