Retroactively enable ZIP 216 before NU5 activation #6399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
added
C-cleanup
daira
reviewed
Feb 2, 2023
daira
reviewed
Feb 2, 2023
daira
previously approved these changes
Feb 2, 2023
str4d
force-pushed
the
6396-retroactive-zip-216
branch
from
5af383d
to
0504594
Compare
This completes the work started in zcash#6000. Closes zcash#6396.
str4d
force-pushed
the
6396-retroactive-zip-216
branch
from
0504594
to
9ce6753
Compare
|
Rebased on |
nuttycom
added
safe-to-build
|
I ran a full reindex with this branch, and was able to reindex up to and past NU5 without errors, confirming that ZIP 216 is compatible with the revealed coinbase outputs before NU5. |
daira
approved these changes
Feb 5, 2023
|
The changes in this PR are correct, but I want to do another review pass over the resulting code to make sure we are completely consistent with zcash/zips#672. |
str4d
added a commit
to zcash/librustzcash
that referenced
this pull request
Nov 30, 2023
As a side-effect, we remove the ability to verify individual transactions with pre-ZIP 216 rules (which we already removed from `zcashd` consensus nodes in zcash/zcash#6000 and zcash/zcash#6399, as all pre-ZIP 216 transactions on mainnet are also valid under ZIP 216).
str4d
added a commit
to zcash/librustzcash
that referenced
this pull request
Nov 30, 2023
As a side-effect, we remove the ability to verify individual transactions with pre-ZIP 216 rules (which we already removed from `zcashd` consensus nodes in zcash/zcash#6000 and zcash/zcash#6399, as all pre-ZIP 216 transactions on mainnet are also valid under ZIP 216).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the work started in #6000.
Closes #6396.