New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REL: upgrade cuilbuildwheel (2.3.0 -> 2.4.0) #3891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If it passes on your branch, merge it.
actually it doesn't, I'm reporting a regression upstream. |
Well then! ;-) |
Here's the report pypa/cibuildwheel#1078 |
Are you sure this isn't a problem unrelated to cibuildwheel, but numpy? See (and/or comment on) scipy/oldest-supported-numpy#45. |
All I can say for sure is that the newest version of CBW fails the build, while 2.3.0 didn't. Maybe the internal setuptools upgrade is actually the problem. |
reopening because the problem was addressed upstream with a new version of numpy shipping with Windows 32bits wheels, and a new version of oldest-supported-numpy to reflect it. Also the build time of this job is now 25% shorter. |
Actually just figured out how to trigger this workflow for PRs that change it, so we don't need to runs jobs manually or on forks to validate such an update. I won't self merge after all since this new patch wasn't reviewed yet. |
switching to draft, will try to enable macOS arm builds while I'm at it |
@matthewturk do you want to have another look at this ? |
PR Summary
Simple one line patch so we can use the current version of cibuildwheel for our next release
the one patch that I think is relevant to us is: pypa/cibuildwheel#975
see complete release notes : https://github.com/pypa/cibuildwheel/releases
A test job is running on my fork for this branch: https://github.com/neutrinoceros/yt/actions/runs/2140271185