Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: upgrade cuilbuildwheel (2.3.0 -> 2.4.0) #3891

Merged
merged 3 commits into from May 2, 2022

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Apr 9, 2022

PR Summary

Simple one line patch so we can use the current version of cibuildwheel for our next release

the one patch that I think is relevant to us is: pypa/cibuildwheel#975

see complete release notes : https://github.com/pypa/cibuildwheel/releases

A test job is running on my fork for this branch: https://github.com/neutrinoceros/yt/actions/runs/2140271185

@neutrinoceros neutrinoceros added enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc labels Apr 9, 2022
@neutrinoceros neutrinoceros added this to the 4.0.3 milestone Apr 9, 2022
@neutrinoceros neutrinoceros marked this pull request as draft April 9, 2022 10:12
matthewturk
matthewturk previously approved these changes Apr 9, 2022
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If it passes on your branch, merge it.

@neutrinoceros
Copy link
Member Author

actually it doesn't, I'm reporting a regression upstream.

@matthewturk
Copy link
Member

Well then! ;-)

@neutrinoceros
Copy link
Member Author

Here's the report pypa/cibuildwheel#1078
This upgrade isn't necessary for the release, as long as the currently pinned version continues to work, so let's just close this for now. I'll just reopen in case the problem can be adressed from our side or if a new, fixed version of cibuildwheels lands before we need it.

@neutrinoceros neutrinoceros deleted the upgrade_cbw branch April 9, 2022 14:52
@henryiii
Copy link

Are you sure this isn't a problem unrelated to cibuildwheel, but numpy? See (and/or comment on) scipy/oldest-supported-numpy#45.

@neutrinoceros
Copy link
Member Author

All I can say for sure is that the newest version of CBW fails the build, while 2.3.0 didn't. Maybe the internal setuptools upgrade is actually the problem.

@neutrinoceros neutrinoceros restored the upgrade_cbw branch April 18, 2022 13:22
@neutrinoceros neutrinoceros reopened this Apr 18, 2022
@neutrinoceros
Copy link
Member Author

reopening because the problem was addressed upstream with a new version of numpy shipping with Windows 32bits wheels, and a new version of oldest-supported-numpy to reflect it. Also the build time of this job is now 25% shorter.
I'll merge after all tests pass.

@neutrinoceros neutrinoceros modified the milestones: 4.0.3, 4.1.0 Apr 18, 2022
@neutrinoceros neutrinoceros marked this pull request as ready for review April 18, 2022 14:15
@neutrinoceros
Copy link
Member Author

Actually just figured out how to trigger this workflow for PRs that change it, so we don't need to runs jobs manually or on forks to validate such an update. I won't self merge after all since this new patch wasn't reviewed yet.

@neutrinoceros neutrinoceros marked this pull request as draft April 19, 2022 17:04
@neutrinoceros
Copy link
Member Author

switching to draft, will try to enable macOS arm builds while I'm at it

@neutrinoceros neutrinoceros marked this pull request as ready for review April 19, 2022 18:08
@neutrinoceros
Copy link
Member Author

@matthewturk do you want to have another look at this ?

@neutrinoceros neutrinoceros merged commit d9e7e0e into yt-project:main May 2, 2022
@neutrinoceros neutrinoceros deleted the upgrade_cbw branch May 2, 2022 18:50
neutrinoceros added a commit to neutrinoceros/yt that referenced this pull request May 6, 2022
@neutrinoceros neutrinoceros modified the milestones: 4.1.0, 4.0.4 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants