BUG: fix an UnboundLocalError #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
bug
code frontends
matthewturk
previously approved these changes
Apr 19, 2022
|
I wouldn't oppose that. Maybe give it a week or two in case we catch another new problem ? Feel free to setup a new milestone |
|
@matthewturk btw I think the code tour workflow is still broken in that the repo secret it's supposed to use doesn't exist ? For now I don't know how to make the job pass |
|
I'll fix the code tour in a subsequent PR - I think I messed up the GHA for it. |
neutrinoceros
force-pushed
the
hotfix_unbound_error
branch
from
4b813f6
to
312b3b1
Compare
neutrinoceros
changed the title
matthewturk
previously approved these changes
May 4, 2022
|
You can merge, but I think we need a follow up fix |
neutrinoceros
force-pushed
the
hotfix_unbound_error
branch
from
312b3b1
to
97b431c
Compare
|
Actually I think I only needed to update the reference commit in the code tour. Should be good now. |
neutrinoceros
force-pushed
the
hotfix_unbound_error
branch
from
97b431c
to
bba9ef7
Compare
|
@matthewturk if you're up for it, I would like to backport this |
|
Sounds good.
…On Fri, May 6, 2022 at 7:23 AM Clément Robert ***@***.***> wrote:
@matthewturk <https://github.com/matthewturk> if you're up for it, I
would like to backport this
—
Reply to this email directly, view it on GitHub
<#3898 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXOYJCLHCUN2BBSBMRDLVIUFLTANCNFSM5TYSQVAQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@matthewturk this should be the last PR to merge before we can release 4.0.4 |
matthewturk
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a follow up to #3816 where I missed a break statement, which can lead to an
UnboundLocalErrorbeing raised, as noted by @Gustav-Madsen on Slack.